From: Stephen Boyd <swboyd@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hung-Te Lin <hungte@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Anton Vasilyev <vasilyev@ispras.ru>,
Colin Ian King <colin.king@canonical.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alexios Zavras <alexios.zavras@intel.com>,
Samuel Holland <samuel@sholland.org>,
Allison Randal <allison@lohutok.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: google: update vpd_decode from upstream
Date: Wed, 07 Aug 2019 07:59:47 -0700 [thread overview]
Message-ID: <5d4ae764.1c69fb81.f81f8.054c@mx.google.com> (raw)
In-Reply-To: <20190807135834.GA12853@roeck-us.net>
Quoting Guenter Roeck (2019-08-07 06:58:34)
> On Fri, Aug 02, 2019 at 03:27:54PM -0700, Stephen Boyd wrote:
> > Quoting Hung-Te Lin (2019-08-02 01:20:31)
> > >
> > > -static int vpd_section_attrib_add(const u8 *key, s32 key_len,
> > > - const u8 *value, s32 value_len,
> > > +static int vpd_section_attrib_add(const u8 *key, u32 key_len,
> > > + const u8 *value, u32 value_len,
> > > void *arg)
> > > {
> > > int ret;
> > > @@ -246,7 +246,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
> > >
> > > static int vpd_sections_init(phys_addr_t physaddr)
> > > {
> > > - struct vpd_cbmem *temp;
> > > + struct vpd_cbmem __iomem *temp;
>
> The change to __iomem should also be a separate patch.
>
Please don't change it back to __iomem. See commit ae21f41e1f56
("firmware: vpd: Drop __iomem usage for memremap() memory") for why.
next prev parent reply other threads:[~2019-08-07 14:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 8:20 [PATCH] firmware: google: update vpd_decode from upstream Hung-Te Lin
2019-08-02 22:27 ` Stephen Boyd
2019-08-07 13:58 ` Guenter Roeck
2019-08-07 14:59 ` Stephen Boyd [this message]
2019-08-07 16:50 ` Guenter Roeck
2019-08-29 10:19 ` [PATCH v2] " Hung-Te Lin
2019-08-29 11:24 ` Greg Kroah-Hartman
2019-08-29 11:45 ` [PATCH v3] firmware: google: check if size is valid when decoding VPD data Hung-Te Lin
2019-08-29 14:51 ` Stephen Boyd
2019-08-30 2:23 ` [PATCH v4] " Hung-Te Lin
2019-08-30 5:03 ` Stephen Boyd
2019-08-30 16:54 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4ae764.1c69fb81.f81f8.054c@mx.google.com \
--to=swboyd@chromium.org \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hungte@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=samuel@sholland.org \
--cc=tglx@linutronix.de \
--cc=vasilyev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox