From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A953C3A5A0 for ; Mon, 19 Aug 2019 15:00:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4962C206BB for ; Mon, 19 Aug 2019 15:00:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ar9Jrh4n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfHSPA1 (ORCPT ); Mon, 19 Aug 2019 11:00:27 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:36417 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfHSPA1 (ORCPT ); Mon, 19 Aug 2019 11:00:27 -0400 Received: by mail-pl1-f196.google.com with SMTP id f19so687623plr.3 for ; Mon, 19 Aug 2019 08:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:from:cc:to:user-agent:date; bh=4/ly6HPt9MuSlzZVKb1ZNAGpaR6hbnk1w3F3lAizCZ4=; b=Ar9Jrh4n+AxhKzP3E82xxRgt2f+w/m6g4fAd6hwOBXEa8l/QrnLpoN4L7C069Hg8BB vZXE0fAQBBbJSjdU1n9SB8DFoICNk7mMyUqKzimsj0zdlhkBe8Kx5T0EmHMPBgP0ATMz AUCmp8VYtXTTfsME6UtuwQdb7Xqhdy6Kf5RQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:from:cc:to :user-agent:date; bh=4/ly6HPt9MuSlzZVKb1ZNAGpaR6hbnk1w3F3lAizCZ4=; b=cyT5xA3mhdfxntpkFM41wdaifL4yltYMne6Ms1UMwXMzyRpn4eWReaocOx1KPVcPdo 4uS/D1+AXEve6XTupX4QowbGwRWehLbC1Qjt7R6CC8iGSBOT3JbuR96p54R1gN5cCPGE Sq1W47yrMOxIaL2HI5TEIjOGaKLt21gXzruTbI+/Fjh94rZmLVW+artCxlG6arV9bBDY jaUfZ9VTfBlWks8MdFwJW7OthRNHkZm5uE5ZClaoZfgMe3DlO9O3bUJGzQ0TcSDAMSlD UV8VccmqH34BXyaDHJbugM+FUlHfKW8mpS5EVfwDJ0DoUPOv1BO2gUAETigSVJ3PDFUg o6Fw== X-Gm-Message-State: APjAAAUQfdijrHJiS7iquPRtKBjLH3s116QMZn2uxanlSaoP3FVF2t/7 +LYGKJ481S17k9F+becY0myEKQ== X-Google-Smtp-Source: APXvYqwWSSEhuqR8SWJi61MDpoeQJR8uCtSX1ClwlPzGOBoOLAQPhjydycFVO+27j6jBePK611onXA== X-Received: by 2002:a17:902:20e3:: with SMTP id v32mr21840810plg.142.1566226826298; Mon, 19 Aug 2019 08:00:26 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id t9sm18324720pgj.89.2019.08.19.08.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2019 08:00:25 -0700 (PDT) Message-ID: <5d5ab989.1c69fb81.6c07e.bcce@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <49fc7c64-88c0-74d0-2cb3-07986490941d@ti.com> <5d5a4150.1c69fb81.3faa2.eee8@mx.google.com> Subject: Re: Suspend/Resume Broken on AM43/AM33 Platforms From: Stephen Boyd Cc: Linux-OMAP , Linux Kernel Mailing List , "Kristo, Tero" , Dave Gerlach To: Keerthy , Tony Lindgren , herbert@gondor.apana.org.au User-Agent: alot/0.8.1 Date: Mon, 19 Aug 2019 08:00:24 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Keerthy (2019-08-19 00:27:13) >=20 >=20 > On 19/08/19 11:57 AM, Stephen Boyd wrote: > > Quoting Keerthy (2019-08-18 21:24:58) > >> Hi Stephen, > >> > >> commit 03a3bb7ae63150230c5de645dc95e673ebf17e1a > >> Author: Stephen Boyd > >> Date: Mon Aug 5 16:32:41 2019 -0700 > >> > >> hwrng: core - Freeze khwrng thread during suspend > >> > >> Commit seems to be breaking suspend/resume on TI AM43/AM33 platforms. > >> > >> > >> rtcwake: wakeup from "mem" using /dev/rtc0 at Sun Nov 18 02:12:12 2018 > >> [ 54.033833] PM: suspend entry (deep) > >> [ 54.037741] Filesystems sync: 0.000 seconds > >> [ 54.062730] Freezing user space processes ... (elapsed 0.001 second= s) > >> done. > >> [ 54.071313] OOM killer disabled. > >> [ 54.074572] Freezing remaining freezable tasks ... > >> [ 74.083121] Freezing of tasks failed after 20.003 seconds (1 tasks > >> refusing to freeze, wq_busy=3D0): > >> [ 74.092257] hwrng R running task 0 289 2 > >> 0x00000020 > >> [ 74.099511] [] (__schedule) from [] > >> (schedule+0x3c/0xc0) > >> [ 74.106720] [] (schedule) from [] > >> (add_hwgenerator_randomness+0xb0/0x100) > >> [ 74.115358] [] (add_hwgenerator_randomness) from > >> [] (hwrng_fillfn+0xc0/0x14c [rng_core]) > >=20 > > Thanks for the report. I suspect we need to check for freezer in > > add_hwgenerator_randomness(). I find it odd that there's another caller > > of add_hwgenerator_randomness(), but maybe the ath9k driver can be > > converted to some sort of hwrng driver instead of calling into the > > kthread directly. > >=20 > > Anyway, can you try this patch? >=20 > I applied the below patch on top of latest next branch. >=20 > Fixes the issue. >=20 Cool thanks. I'll send an official patch now.