Re: [PATCH v4 4/6] tpm: tpm_tis_spi: Export functionality to other drivers

Stephen Boyd
2019-08-22T17:29:35Z

Quoting Jarkko Sakkinen (2019-08-21 10:58:46)
> On Mon, Aug 19, 2019 at 10:10:08AM -0700, Stephen Boyd wrote:
> > Quoting Jarkko Sakkinen (2019-08-19 09:40:05)
> > >
> > > Instead there should be a single tpm_tis_spi driver that dynamically
> > > either TCG or CR50. I rather take some extra bytes in the LKM than
> > > the added complexity.
> > >
> >
> > Ok. I had that patch originally[1]. Do you want me to resend that patch
> > and start review over from there?
> >
> > [1] https://lkml.kernel.org/r/5d2f955d.1c69fb81.35877.7018@mx.google.com
>
> What if:
>
> 1. You mostly use this solution but have it as a separate source module
> only.
> 2. Use TPM_IS_CR50 only once to bind the callbacks.
>

Ok I think I understand. Take the callback approach from these patches
and combine that with the TPM_IS_CR50 changes I made in [1]. I'll try it
out and resend.