Re: [PATCH v3 2/5] staging: rtl8723bs: rtw_mlme: fix lines exceeding 100 columns

Luka Gejak
2026-04-27T16:03:00Z

On April 27, 2026 5:46:34 PM GMT+02:00, Salman Alghamdi <me@cipherat.com> wrote:
>On April 27, 2026 12:10 +03, Dan Carpenter <error27@gmail.com> wrote:
>
>> This patch is too big and too complicated. If you send a patch that
>> only adds newlines, then I have automated ways to review that but
>> when you're adding variables and change code to use min_t() then
>> it's hard to review.
>
>The introduction of some variables was made in order to fix line
>length for certain function calls that has long named parameters.
>Should I separate long line fixes into two patches, one only for
>simple newlines and the other that introduces variables?

Yes, that could work.

>
>> When you start doing things which are more complicated than
>> just adding newlines, then it gets controversial in ways you
>> don't expect. For example, we don't really use min_t() these
>> days.
>
>I tried using min() first as Luka noted me, but checkpatch.pl warned
>to replace it with min_t() instead. What is the preferred function
>to use in this case?

You could use umin() since both of these are unsigned, but check that
just in case.

>
>Regards,
>Salman Alghamdi
>
Best regards,
Luka Gejak