Re: [PATCH 1/4] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding

Amit Kucheria
2019-12-03T16:54:11Z

On Thu, Sep 19, 2019 at 7:48 AM Thara Gopinath
<thara.gopinath@linaro.org> wrote:
>
> Introduce a new binding parameter to thermal trip point description
> to indicate whether the temperature level specified by the trip point
> is monitored for a rise or fall in temperature.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index ca14ba9..849a2a9 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -90,6 +90,14 @@ Required properties:
> "critical": Hardware not reliable.
> Type: string
>
> +Optional property:
> +- monitor-falling: Indicate whether the system action is kick

Stray space after :

> + Type: boolean started when the temperature falls below or rises

Unnecessary tab after boolean (I'll fix up the rest of the file in the
yaml conversion)

I suggest not making this boolean. Just use the property as a flag by
itself to denote a falling trip point. No need to deal with true/false
values.

Similarly, the sysfs file would show up only in case of a trip that
sets this flag and just contain a 1, for example.

> + above the trip temperature level indicated in
> + "temperature".If true, the trip point is monitored

Add space after full stop.

> + for falling temperature else the trip point is
> + monitored for rising temperature.
> +
> * Cooling device maps
>
> The cooling device maps node is a node to describe how cooling devices
> --
> 2.1.4
>