public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Sameer Pujar <spujar@nvidia.com>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<mkumard@nvidia.com>, <devicetree@vger.kernel.org>,
	<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes
Date: Thu, 20 Jun 2019 11:01:05 +0100	[thread overview]
Message-ID: <5da5b498-cbc7-26dd-bd68-7f2376eb6b30@nvidia.com> (raw)
In-Reply-To: <20190620093929.GI26689@ulmo>


On 20/06/2019 10:39, Thierry Reding wrote:
> On Wed, Jun 19, 2019 at 05:21:21PM +0530, Sameer Pujar wrote:
>> Add DT nodes for following devices on Tegra186 and Tegra194
>>  * ACONNECT
>>  * ADMA
>>  * AGIC
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>>  changes in current revision
>>    * updated ranges property for aconnect
>>    * renamed agic node
>>
>>  arch/arm64/boot/dts/nvidia/tegra186.dtsi | 67 ++++++++++++++++++++++++++++++++
>>  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 67 ++++++++++++++++++++++++++++++++
>>  2 files changed, 134 insertions(+)
> 
> Applied to for-5.3/arm64/dt, thanks.
> 
> I ended up deciding to put the aconnect node among the nodes with unit-
> addresses, in the numerical order that it would fit in if the top-level
> aconnect node didn't exist. I think that looks much more consistent in
> the end, even though it's slightly bending the rules that we have.

Thanks. Good point, I had not thought that bit through. Works for me,
especially as the aconnect bus has a ranges property and so is
associated with an address range.

Cheers
Jon

-- 
nvpublic

      reply	other threads:[~2019-06-20 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19 11:51 [PATCH v6 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes Sameer Pujar
2019-06-19 11:51 ` [PATCH v6 2/2] arm64: tegra: enable ACONNECT, ADMA and AGIC Sameer Pujar
2019-06-20  8:37   ` Jon Hunter
2019-06-20  9:39   ` Thierry Reding
2019-06-20  8:35 ` [PATCH v6 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes Jon Hunter
2019-06-20  9:39 ` Thierry Reding
2019-06-20 10:01   ` Jon Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5da5b498-cbc7-26dd-bd68-7f2376eb6b30@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mkumard@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox