Re: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names

Krzysztof Kozlowski
2023-01-18T15:50:10Z

On 18/01/2023 07:16, Yanhong Wang wrote:
> Some boards(such as StarFive VisionFive v2) require more than one value
> which defined by resets property, so the original definition can not
> meet the requirements. In order to adapt to different requirements,
> adjust the maxitems number definition.
>
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index e26c3e76ebb7..baf2c5b9e92d 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -133,12 +133,9 @@ properties:
> - ptp_ref
>
> resets:
> - maxItems: 1

Also, this does not make sense on its own and messes constraints for all
other users. So another no for entire patch.

Best regards,
Krzysztof