From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-ide@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] ata: pata_artop: make arrays static const, makes object smaller
Date: Fri, 8 Nov 2019 07:26:57 -0700 [thread overview]
Message-ID: <5dae76cc-e71d-d295-7947-b7005a7f1af3@kernel.dk> (raw)
In-Reply-To: <20191006142956.23360-1-colin.king@canonical.com>
On 10/6/19 8:29 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const arrays on the stack but instead make them
> static. Makes the object code smaller by 292 bytes.
>
> Before:
> text data bss dec hex filename
> 6988 3132 128 10248 2808 drivers/ata/pata_artop.o
>
> After:
> text data bss dec hex filename
> 6536 3292 128 9956 26e4 drivers/ata/pata_artop.o
>
> (gcc version 9.2.1, amd64)
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-11-08 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191006143000epcas2p168872c0c7b1e1879e31931d3244dfd4d@epcas2p1.samsung.com>
2019-10-06 14:29 ` [PATCH][V2] ata: pata_artop: make arrays static const, makes object smaller Colin King
2019-11-08 14:06 ` Bartlomiej Zolnierkiewicz
2019-11-08 14:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dae76cc-e71d-d295-7947-b7005a7f1af3@kernel.dk \
--to=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox