From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755795AbcIJUhA (ORCPT ); Sat, 10 Sep 2016 16:37:00 -0400 Received: from mout.web.de ([212.227.17.11]:52900 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752793AbcIJUg6 (ORCPT ); Sat, 10 Sep 2016 16:36:58 -0400 Subject: [PATCH 13/13] DRBD-receiver: Improve determination of sizes in receive_Barrier() To: drbd-dev@lists.linbit.com, Lars Ellenberg , Philipp Reisner References: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5dd280c1-27ac-4e83-97eb-3a4f7fec6cd9@users.sourceforge.net> Date: Sat, 10 Sep 2016 22:36:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Mt2ycirEgL5GfNHn4yGTTpN/Ifw93gsMU4FEDi5hq4nuV6dnxjF KfmkTBfBWlRxOftI/sT7WhNGqAMXOY5RAl0zcl8a4IWVJYGHalNh8U7wnBJ2hkAuVIVucTY I2P9dYeiLY6g9HAvF0Zx2fOST1d1fhdJAC4N+LPqgyPWYC/WdTVZiSOvRpbmRyUmTq2ozNO tm3xONKVdO1R86ff3oaGg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0iEmneUMLN4=:j3jvs0nzp/cyIvDa6hC+iM G6J7E3HwK/54U02OL/iRiBUuh2rBad/FrG7nkvfLcxJmqm+G3MVeyckvbxSTznax6zfmLWkfE R12LLipmSsdgh5ozcj7bElhXh6HGdVsAd+DoDdU5qqmeLY2VFpcAHMK7QFs5mpxxFWIEqEDRZ QFmg4klk3aq2pz0zV7282s1HiWNaRWKJITbkcWaNZ5ZHM8ob9WuISNKzfGLPXXF2U2lRTzuMX OV/eFhgSZaWOSsEnGK7XnHqcFkDYugltVMm9/i911kSvKZOVxm3pV9R8kpVdGyNAVdIb5C2is TvoqyMc1XQ+32Iiel+jsQrwn0+XZ3yy/xJgfkxaL1pYu0EeOBdH1j4o7f0pzH00L5iawWSdaf jl5E2TpZdqHsxYODt86UPn7tMMldEDbEukPa/pyI5o7e4gSkBX65nHf4xJDvZiFibELJu/aey QhR8gT3LBt/TAUkpDYXP22EkIT/SXtcCSi7Ar+fySXNq+DpgXl/v7njTSXypTaUqaYcwoeXVJ WezZKvQHCIVt3regxEKI5Ya3OO1aHDCE2XO2GWfvMU7zes6vVyGU9DWEgqwh0qI7oYu3vHI2h dlY4pyLvm/Pi6Fv/W2F/RuCh2aG+tOptT+DXdw6RfqRoXWf4OYMT6tZLk+J6Ghmxhk7XYdwN6 Cs67o82yBH4wrdxjj8s+NxVv/N1bxrvQyAfv7pPtnnATCVTcrRnlrS0H0UG3Q/Q5vdlMLZAOZ Ht4+mnBw89EUdxEsC54oj7a+dfZ+QLwU7h4ONSp1x8psAtKuQndXCPwWztSCZIik+HFKQIuxB yGlVnua Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 22:06:21 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/drbd/drbd_receiver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index e4da335..32ac4a9 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -1747,7 +1747,7 @@ static int receive_Barrier(struct drbd_connection *connection, struct packet_inf /* receiver context, in the writeout path of the other node. * avoid potential distributed deadlock */ - epoch = kmalloc(sizeof(struct drbd_epoch), GFP_NOIO); + epoch = kmalloc(sizeof(*epoch), GFP_NOIO); if (epoch) break; else @@ -1760,7 +1760,7 @@ static int receive_Barrier(struct drbd_connection *connection, struct packet_inf drbd_flush(connection); if (atomic_read(&connection->current_epoch->epoch_size)) { - epoch = kmalloc(sizeof(struct drbd_epoch), GFP_NOIO); + epoch = kmalloc(sizeof(*epoch), GFP_NOIO); if (epoch) break; } -- 2.10.0