From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>,
dgilbert@interlog.com, linux-scsi@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
syzbot+5516b30f5401d4dcbcae@syzkaller.appspotmail.com
Subject: Re: [PATCH] scsi: core: initialize cmd->cmnd before it is used
Date: Tue, 2 Nov 2021 16:01:08 -0700 [thread overview]
Message-ID: <5dd944cd-e3be-acb1-3d96-e7939dc7bae8@linaro.org> (raw)
In-Reply-To: <9115c893-3fcd-ae81-7422-723ae5370319@acm.org>
On 11/2/21 15:27, Bart Van Assche wrote:
> On 11/2/21 3:22 PM, Tadeusz Struk wrote:
>> Do you want me to send a patch with the check in scsi_fill_sghdr_rq()?
>> I want to close the mentioned syzbot issue in 5.10. I can also do the
>> back-porting if anything will be required.
>
> Hi Tadeusz,
>
> I think we need two patches: one for the SG_IO code that rejects SG_IO
> requests if the CDB length is not valid and a second patch that removes
> the code from scsi_lib.c for assigning the CDB length. Please let me
> know if you would not have the time to work on this.
Yes, I agree. I will send the patches today.
--
Thanks,
Tadeusz
prev parent reply other threads:[~2021-11-02 23:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 19:24 [PATCH] scsi: core: initialize cmd->cmnd before it is used Tadeusz Struk
2021-11-01 20:06 ` Bart Van Assche
2021-11-01 20:13 ` Tadeusz Struk
2021-11-01 20:20 ` Bart Van Assche
2021-11-02 1:56 ` Douglas Gilbert
2021-11-02 3:06 ` Bart Van Assche
2021-11-02 21:33 ` Douglas Gilbert
2021-11-02 22:22 ` Tadeusz Struk
2021-11-02 22:27 ` Bart Van Assche
2021-11-02 23:01 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd944cd-e3be-acb1-3d96-e7939dc7bae8@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+5516b30f5401d4dcbcae@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox