From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B99C433DB for ; Sat, 30 Jan 2021 18:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28E1B64E11 for ; Sat, 30 Jan 2021 18:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232139AbhA3S6d (ORCPT ); Sat, 30 Jan 2021 13:58:33 -0500 Received: from smtprelay0097.hostedemail.com ([216.40.44.97]:48756 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230168AbhA3S6c (ORCPT ); Sat, 30 Jan 2021 13:58:32 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 2EBA1100E7B46; Sat, 30 Jan 2021 18:57:51 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: dad66_00075af275b3 X-Filterd-Recvd-Size: 1822 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Sat, 30 Jan 2021 18:57:49 +0000 (UTC) Message-ID: <5deee552f4bcfd81c6dc6ec3e8139c0c4ba27d31.camel@perches.com> Subject: Re: [PATCH 06/29] drbd: Avoid comma separated statements From: Joe Perches To: Jiri Kosina , Philipp Reisner , Lars Ellenberg Cc: Jens Axboe , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 30 Jan 2021 10:57:48 -0800 In-Reply-To: <1c8081264d82101d7837220c5ee221c307da5d91.1598331148.git.joe@perches.com> References: <1c8081264d82101d7837220c5ee221c307da5d91.1598331148.git.joe@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. ping? > Signed-off-by: Joe Perches > --- >  drivers/block/drbd/drbd_receiver.c | 6 ++++-- >  1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index 422363daa618..87f732fb5456 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -111,8 +111,10 @@ static struct page *page_chain_tail(struct page *page, int *len) >  { >   struct page *tmp; >   int i = 1; > - while ((tmp = page_chain_next(page))) > - ++i, page = tmp; > + while ((tmp = page_chain_next(page))) { > + ++i; > + page = tmp; > + } >   if (len) >   *len = i; >   return page;