From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbdJ3N4T (ORCPT ); Mon, 30 Oct 2017 09:56:19 -0400 Received: from mail-by2nam01on0075.outbound.protection.outlook.com ([104.47.34.75]:7464 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751572AbdJ3N4Q (ORCPT ); Mon, 30 Oct 2017 09:56:16 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Tom Lendacky , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v6 32/38] KVM: SVM: Add support for SEV DEBUG_DECRYPT command To: Borislav Petkov References: <20171020023413.122280-1-brijesh.singh@amd.com> <20171020023413.122280-33-brijesh.singh@amd.com> <20171027202518.GS12039@nazgul.tnic> From: Brijesh Singh Message-ID: <5e041a3f-823f-08ce-a653-a02b71e2cb6b@amd.com> Date: Mon, 30 Oct 2017 08:56:13 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171027202518.GS12039@nazgul.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM3PR12CA0079.namprd12.prod.outlook.com (2603:10b6:0:57::23) To DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30954645-c62a-4943-16df-08d51f9dfc19 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199);SRVR:DM2PR12MB0156; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;3:mbLZeCTjZwsd9k/lVDnEVSYD1IsuhRkBXNU6M9qCPyi0Tn9ciaWNOvMPCSBbDN2C4f0HzH6vOdZRtpUOXcNlOa3eCg+X/pwXbdhbzbc72LEaMmh3KAuMDaTaO5WPEthLmHySNRQaA6KbH4V9FcZfbV0+CVyHjpo/wlf+dxuuo4Sq7pXnZb3J0HyoGeTIqsK+qSYsdDLZIfqVBXQlQKzVOXYfdRaNzSpbzFZAdKGR5mccehE0rn9jr1mXLlpoFWlX;25:lSHVbKZggB1KeR938gL5kaaIYJqIokGngU2rcZoH00uynPQgBqdGUxajyCd+nBPTYFi3cAb9F7oj5aDyjpfC1YQuMc7Az3bCgSuutRzCTJNYXJIFIX2o6m8XE6I90O48tynrNrCyYvqagQ9nBKssMS4cTJy6EIjxmRdSTgdBUc26Op9trJ8hMs2kqsnAtFZ80yXMsmYp8f1WSkffuYMQLf7S7pworheRiMCWRo5l+IDvbFDz7A9tMAgBaMGmGGVMfntKC9INkLh1pPvsGtx5rokUrshpzcn4FsEQ7IeWwOEyc1qPw1Vktk3etce7KOS0wQ3Q7f7WhRTTvZb1g+ZAUg==;31:ME8Ym+FhbQjRQKWiGM9rmMHJoWXwjMdyfUnf7gBsAATBz9rCoG08xRhhjUfxIGguNq1usjV37jP/6+6l2aEUrzWaEtez5d19S3nokhcYEB5fqA/xlG85R+EVbdwsgezPgoj0lwdY1uuOBxj/pV/yRlBffWwU1alGJVfWtVtl2f4+X0Ne2ZASmizTZNivwTYyX7WkBujVsevoB5VqFNNHO9xXV0JPfFrDd94RSnEOV/c= X-MS-TrafficTypeDiagnostic: DM2PR12MB0156: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:RSxFjbxd5JqiyzyBfzJMbFmJReP8qQ/M99uFocHTik9Ak9MA5hICUAxQabF38kWKvOCy40y+Qyni5INZFVbf+LAI1vdCSvUA9Np/9oUiMlQ0rOCooZs+Z9ER3ilvK2Y1KZMDfhraWrqIN5c/tfl9npAB5jNC7Io+g7Ug8YXQDZwQnjmndD6fipeV5Tii0txSDuXHZJkZ7rACoZu7y9cXSW9TmD4FIo4LiFZCcD17/I9LSOnlOpA22JwUQotS/MGmIKjHyiLRslzfZ0EUH7t6e9LCyEmsf5B+iw/vPTH99SPNbfpEMwh6XqSQuB0ZEC79x4LfUqGbsEH3fpPuMqIarcjVLfw1H/yo0hz6tmQTENXA0dGd4+clg4p050PBEmBEnPGW6DVoQS/cnPFuYYuNgzOkmb7kjRh+stHNikEUWXhWCsJU2OqAKiNJwS0BnTmBvYv0qHN8ef+2nYb3gz9f8laCHg0RmwntoYrMOT2SfXn44Y3GhUYZOQDIQOhsbcpL;4:rbD+Sy44kKGwV0MO6nPO+zaeAP+3yyPbBba1GBqpwYAwYhnoZl3nFGMJdWKmJnY7Abvkhhlapm0yLcxFgrvCL1nYxLP9gg1TeEUE7Dyy3Im7xdqKiBMVElutKxCQkkCxaD/6KVCXGWfafcObs3e/3mS5NGwrZgfxhmf3wOUjnA0KX4Emd0FLbU7fXPpC9GaW27BQcqaGQV8uILKAL7iJUEWH+wzN5DyN3EpZFd3SFFyyd+BC7WZujdV0Gf6ygwYSPLh4eJ5lvWG9WH5ftEObqA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3231020)(3002001)(6055026)(6041248)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0156;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0156; X-Forefront-PRVS: 0476D4AB88 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(376002)(346002)(189002)(24454002)(199003)(83506002)(6246003)(3846002)(6116002)(5660300001)(316002)(229853002)(97736004)(101416001)(65826007)(47776003)(54906003)(53416004)(105586002)(6916009)(2950100002)(106356001)(36756003)(2906002)(7416002)(2870700001)(7736002)(33646002)(86362001)(6486002)(68736007)(305945005)(64126003)(31686004)(8936002)(25786009)(23676002)(53936002)(53546010)(4326008)(31696002)(65956001)(50466002)(65806001)(66066001)(58126008)(189998001)(54356999)(76176999)(50986999)(478600001)(8676002)(81156014)(16526018)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0156;H:wsp101258wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU2OzIzOkkyNzBTK21NTzQ4cHRxNzhocExFUTlNNmZ0?= =?utf-8?B?ejJwb3BOVi8xRlZMZkJGR1NqS3VPU3pBZ1ZMM3l0VHoxVnRJUUo5TGU4R2FS?= =?utf-8?B?WmxkMnNxSVFqQkFlWVRsR3kyUisxemJqeFRlT0dMQ0g4QWZham9RTlljMlFW?= =?utf-8?B?UElzL1diVGRNUEY3Mk5sQ2tUb0tJNVpLejcrRjdTRTl2VGFCTnhMR1BHKyt2?= =?utf-8?B?ZVBrR2JkcVZDUnJkVTdHOXNIWmpWVlVNVi90aGJ6MWJaNVZoNm5SMjBRVkp5?= =?utf-8?B?Rml0anp0STFiVGxwb3gwMStjNjlCVGNldEtHNnZabVI0UUkvaVFCaXQ2R0FN?= =?utf-8?B?U1RpNXREUGd6S0d1WlkvTW1sWlFlMVlDQjhDR1dZcWx1NXBUTXRLYXVYYU1q?= =?utf-8?B?OW52UG5EL29PMEhxR0tpbklHK3NDTElYcTNoa2pKYjY5ZitDTjVlY0kzckgv?= =?utf-8?B?NzFLbUZoU01oNFM4eFRSWWRWeGZ0eGFwZVMxNTBtSHBDTHdxNGJMZlpDeGVu?= =?utf-8?B?SmhyRTJuYjhxUTBlelZUeE1iZG1aVWdLcGdDMUJJeVRLWVhLMFRMMGMvZHRE?= =?utf-8?B?TThqbmtCTElGbmNFWForcDBBRUcxUzExTGJ1YTNza1RkVnZSQkRiUm5UaXUr?= =?utf-8?B?RmtQenVRMlZqQTNqV3JLTm5FNGY2Z21BNEZBcElxcTVmanhaQ2xabFBZWFUw?= =?utf-8?B?M0FYcy95N3FVcGNPb3BpU09OYk5TV3JzNmlWZlBVanIrQ2NvRDlvNmJZWjBD?= =?utf-8?B?UlMxNzNSdEZRRkhlVFgrL3dMbHR1U2oySTUyN2U1dlgzZXJhenJXU1h6TjRC?= =?utf-8?B?Q1U5cytiODhyZHRPazFrMWJlZm1UdXgwVXBlS0NLbXB0ajVZeWVTbm5jemRX?= =?utf-8?B?SFVGMVhFRlZ6U0tKWGZ5Wmd2Z1luS3ZlcnNpZHFVZlVvQXdOYmNqZkFaK3VE?= =?utf-8?B?S093b3A0VHh2blJOZU1vbHovS05OWnVxTlhxdmlWaDMxaStITVhZZ2FMSWpR?= =?utf-8?B?aTFmS0pRa29BajVmeTFkcXFUa3RCUFlBdlduZmF1ZVI5am41d3RSU0tSQmIv?= =?utf-8?B?bHgvczhUbTBLMWRkazB3MXBld2NXTUx4YUZodUJBUGFBcW9xdmhnbHVXTzdK?= =?utf-8?B?b3VjTjFmZDZOSGxzWFVudlpJYnN2b3hraHc1blFjQ0VXdVV4SjJqbFVxT0dQ?= =?utf-8?B?VUZhSEdJR1pDdHgrenZ6MmZzUGJpUUZBK3FsOG1ZcXJrWEdMM2NVOS9ocFJx?= =?utf-8?B?N01WbUIwVldKMVNJK1gyRkdoVWYyVjhsZW1vdkx2NFNjd2kxcDlRNGxJcUVF?= =?utf-8?B?WTZjc0Z1NVY0ZjhDQnByWmJlcGN5d05TeFVEOVFiTkZWbFZGQnFkZFJnUnJP?= =?utf-8?B?VjloQWVvUUlsdnVKMlQ4ZW9UZy9LcDE2c2YwbUxmenUyQXFQUzlPbGFXSU8x?= =?utf-8?B?WUxkcThjV3oyTWlRN2UzV2d3WE50bDRZSXFTU3orN2IxRnpBMkJ1V1RNZVJP?= =?utf-8?B?cHFVMi9jdE9zcE40U21MNmRLTStEN2hEYy9oWm9MYkxkSGFSV3dEVHYvNXZP?= =?utf-8?B?a3lpTk5pZUNOZ0NvUVRpWWZsK1ZoakVnY0QyN3lhZVJ2OWVTOHBxS3UzNkpj?= =?utf-8?B?QnIxNTlobGF2dmFKbmRBWUsyQURrTWdJb2pnbWFxQXgvNG1WbHFsYW9FVlRi?= =?utf-8?B?OG1oRnpSblRzM2Qxcjlrc3ZoNzZoWWYrVVV3UVduWGF2VWwzWkVoWGdTTVpK?= =?utf-8?B?b0JpdllNTnJnOE9iTDM5TFZNbVVFRlRLeWlWU1N3NCtMVnVpMSs3QnVWNzV4?= =?utf-8?Q?uk5M/r5kk0oJ8?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;6:mkL1zXeCYakPPV9yDS6RU0EVhmeuMPD4ZAvezmflPyYdyMieNJYpkMrBop6jOMp2YzbSAzWGoWNsImQz6OL8LJ6h1CnJyMwW+YqjjsdxwmCqtV7oHYpqc1JOUmikBPaYJw5CWp3WGZiGbxn9j1stmNy17wa+8f4MU0UELSovT7PgAtB1wIu2qCfjee1JiDgb3sSf0dPWc3/NJFKZIcupZUDSi/7Hzpx6EPOO1I7gSIKKHTu77qD+PRbVhyVu1v2HVq45eDIq2AeQb5L/X/K5B/Fokd2H3tZ05VBrMy5QY227kIqPxlNXzJIlr2cRbDL2jeoI5UjTuQNKsN5IIlp05bmUz9ERoLJ2ET6so0lHT2g=;5:UnMz/B8bj//fA6rFEUoGAFNuKArvNK2U6AMn83RFyPymvunWr4hb4mldeAe8IiijTPqGvDqtvXIWtbLrxoIDrSg1DT3EFwccXDz4bBUkLQZy27aA+6/87k+j7H85aJ+26+gXZF6qFkeDBt9NwR1RJiGVmLpmxP0oI9JX22zv9JM=;24:h4MJtsX8DH3gHubzG2IDxxVCL+fYhQY48nORKhq0uc04QVIWkZvGgkBaSJQilj4FMWsvwKCO0uCX/sWRSJ1Xloa5kkBl/r1Dm0kD93vg58w=;7:Ybf3rTCpP7ZD2LBCDwL1KFquW2R0hyMVApYalJQ+4DhiVOTiF9j4jAucvRWP7m2iIRchQJt1V48fPHulDZtIxeYOBJAQp9rHqqAkMUkljpyv2RyE8Pnp3xntg+KnvBXrRVDQGXbCS5YyeGp1oZP0dkDS3uUkP9vnBCKlgCBilpQuqlaHnAUVPr5gCcfZD1x2GlnPu2u6Av9yq2pgBjSZY5HZikmkH7XTNRDfY+wm28CnFaj1wrhOIzKlmzvZrPoN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:dU5HXtCv6KkD1jewTsfRRi7Winsx9ocUQVZR7Oj/w5Gj3OP335Pesb6MCk+duPhWf39DziTI8PvCUDAdiPVgmF+uNiio210xJGoArp4puE3vPjVrULAdemKG7NOlCrQZ79uOcSTvLcvN9HpQVV43cBXcboV1/hG6zsBhefQ1TPFjv+x1ENueQ2Uju+MFjKSBA+c4b0z0OZi7J9wQOt5+AwbkOE4WFYV8Rl+IhlGNV/wXALM/7RW/qGG7vjshOZR1 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2017 13:56:13.3716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30954645-c62a-4943-16df-08d51f9dfc19 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/17 3:25 PM, Borislav Petkov wrote: ... >> + ret = -EFAULT; >> + } else { >> + memcpy((void *)dst_kaddr, page_address(tpage) + offset, size); > arch/x86/kvm/svm.c: In function ‘svm_mem_enc_op’: > arch/x86/kvm/svm.c:6115:4: warning: argument 1 null where non-null expected [-Wnonnull] > memcpy((void *)dst_kaddr, page_address(tpage) + offset, size); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ./arch/x86/include/asm/string.h:4:0, > from ./include/linux/string.h:18, > from ./include/linux/bitmap.h:8, > from ./include/linux/cpumask.h:11, > from ./arch/x86/include/asm/cpumask.h:4, > from ./arch/x86/include/asm/msr.h:10, > from ./arch/x86/include/asm/processor.h:20, > from ./arch/x86/include/asm/cpufeature.h:4, > from ./arch/x86/include/asm/thread_info.h:52, > from ./include/linux/thread_info.h:37, > from ./arch/x86/include/asm/preempt.h:6, > from ./include/linux/preempt.h:80, > from ./include/linux/hardirq.h:4, > from ./include/linux/kvm_host.h:10, > from arch/x86/kvm/svm.c:20: > ./arch/x86/include/asm/string_64.h:31:14: note: in a call to function ‘memcpy’ declared here > extern void *memcpy(void *to, const void *from, size_t len); > ^~~~~~ > I am not able to reproduce the build warning in my setup, what config option or compiler you are using to  trigger this issue ?  I am on Fedora with gcc 6.4.x. Logically, the code looks okay. I can try to rearrange code to fix the warning. I have not touched this function since couple of rev, have u seen similar warning in previous versions (v5, v4 etc). thanks -Brijesh