From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932570AbcHKM1H (ORCPT ); Thu, 11 Aug 2016 08:27:07 -0400 Received: from mout.web.de ([212.227.15.4]:57355 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932507AbcHKM1D (ORCPT ); Thu, 11 Aug 2016 08:27:03 -0400 Subject: [PATCH v5 2/2] mfd: dm355evm_msp: Change error messages in add_child() To: Lee Jones , kernel-janitors@vger.kernel.org References: <80dc4486-01d1-df66-c9c2-b71ee2251251@users.sourceforge.net> Cc: LKML , Julia Lawall From: SF Markus Elfring Message-ID: <5e0c3af5-5efd-2e7e-020a-5c7304131cc1@users.sourceforge.net> Date: Thu, 11 Aug 2016 14:26:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <80dc4486-01d1-df66-c9c2-b71ee2251251@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:WUKCFgrsOTCe+P5Q3SA6q25xqOVZLo2Izk2XQgg5xMqkkJacZQV +XAG+2tb+oe4MoVJjUObv6sEvJcj7UJOMt7Y3cVq9lvTTXTFJrbqh1QyhpIAmKKUZOs1I/R n2cNO0cFXnMY6wo3nyaKIc/iUoJSw/KEJwzZcZZboxLed2HgQDQjfXF3v/Gb+Xmc9xmpX+b JWyJFN2qAD1keMZRmocbQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:uIsC25gYDz0=:JwAZl5dmvP8tK81BOg2FXE NU76ZHSM6pM7Izs89Arn/yyuFxDpxWwZMTUSCL+mfZZP8cAvhDtspixSp59JC9S+ibKDvxIvU OsyjwkcFSET90l4nnp3nRBEoBWqlFgZJSI6ndnVJ4Tm2zoePX0xcxRZXP/d2/kkXHdsBxlphJ NrYyJ1/o6CY4dVAIzGWIe54NVz9LHiYuOB6LU9mTMcapP+HOy0k5MlfUq8RckVy22YxbMuCFt 4Mfry8Gt1qC1RpekwAjMdH1EiBKfA2TtNvVyqzxLIhj84y/y6nq/TDvQ0XEBtdSZr4e9su4Sd dWLYEHa2/qshdQtQjLf2DtLl8gS7Y0F/7hcs1tDJl6zUBM7XrHGUOgPSFvE9VoNdxxiCHN4gx 1xLhrfcyxlUVuVa+OnCAg4aUP47Yzcub4XV4ep4d5UDMFW4aatCbmdzZ8LRY4Gy3gQVE58cYS GKBM63OtfODIlKXlFe6haJvBWQBI748GUyfA/vmsaArYz1HXoxefLzT9V2p8R6G5KwbRj3/MK priwEqXiBqcGuw1v8hlPSOUwhEW+tGqsemYJjLmMDari0Mp/ZxO1X2VpkIrdnZJ3VaKIAhsoa gOcx7Ahpk2shDB5pq/s+ZqHlh2S1o9mEou+0wiantIJ0fQ0acF6p9o9YCYfBuixdFkRhaykKz B4cUIg6hJ+X9FNB9XAqOALjtHEuXCBj4Ld8lfjEX9z1Sz2cc+99DPuY/keuAAuUnNG6Cjwxdc rQGA7on2iq+V983NXOg73C/m1ICsbhH7IMin7YFfxSa3eZGlL3daSJEM2dQyLpQT69oxj2qc2 s5LKQlM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 11 Aug 2016 14:00:43 +0200 Delete an error message at the end while increasing the importance of related information. Link: https://lkml.kernel.org/g/<20160809153615.GU5243@dell> Suggested-by: Lee Jones Signed-off-by: Markus Elfring --- v5: Rebased on the source files from Linux next-20160809. Requested changes were applied. drivers/mfd/dm355evm_msp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c index 86eca61..463f9e2e 100644 --- a/drivers/mfd/dm355evm_msp.c +++ b/drivers/mfd/dm355evm_msp.c @@ -208,7 +208,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, if (pdata) { status = platform_device_add_data(pdev, pdata, pdata_len); if (status < 0) { - dev_dbg(&pdev->dev, "can't add platform_data\n"); + dev_err(&pdev->dev, "can't add platform_data\n"); goto put_device; } } @@ -221,7 +221,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, status = platform_device_add_resources(pdev, &r, 1); if (status < 0) { - dev_dbg(&pdev->dev, "can't add irq\n"); + dev_err(&pdev->dev, "can't add irq\n"); goto put_device; } } @@ -234,7 +234,6 @@ static struct device *add_child(struct i2c_client *client, const char *name, put_device: platform_device_put(pdev); - dev_err(&client->dev, "failed to add device %s\n", name); return ERR_PTR(status); } -- 2.9.2