From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A06C3F68F for ; Fri, 10 Jan 2020 16:52:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6FEE20673 for ; Fri, 10 Jan 2020 16:52:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lR9Qv/Rh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728640AbgAJQww (ORCPT ); Fri, 10 Jan 2020 11:52:52 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:40771 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728107AbgAJQwv (ORCPT ); Fri, 10 Jan 2020 11:52:51 -0500 Received: by mail-pl1-f194.google.com with SMTP id s21so1065336plr.7 for ; Fri, 10 Jan 2020 08:52:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:subject:to:from:user-agent:date; bh=SC0UnYuTvxE5OcA375X4sqDX8RR6HMTTrFTXJph6jSE=; b=lR9Qv/Rh2eYbSmBp73Q6BrJGiZOTHErsCfUcGyDbgXcFuMwI36N47x623pr35oqewC DhPd2mZievnpOgj2/IiBIrrrgWgM/jIO2/qryR72NyThU0yuyTlTTrr0uzsWTYuLb8c5 JXTo8xNNKwipDeHFgPXASuqAGBA2+0k71Vr1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:subject:to:from :user-agent:date; bh=SC0UnYuTvxE5OcA375X4sqDX8RR6HMTTrFTXJph6jSE=; b=TBbOJMYlr9rlLVB/I3bljPwp+ngOt/O6CvehXDjd755Y2zzTqy/Bbic1QkKXvjTYFV Zid0q1v3ZzfDjvqLWuE/ToVMtn5eZ/xASOl6bkrxDiBOPzAyLQX/taryqRwMxn3o7Y0H ZQudh8sd1NOZj9kQZ22T8UMU06yBMZsKKqGNfVzRA5XTSZIuw1SzDLUzDIJLVXuxQzYU R76/FAI3C+eU+HuNzZ/E8ybXbHEuJUF63ZhfWAugMK+waOlXqTtIRDPv3V2K3Buo/rQ6 aqZJfIAGzN/MRniqSFxlpHrorlCOABVCdixPnJjlt9rY9bHlnvY/mOYwLJbcOqLbtNtE nNww== X-Gm-Message-State: APjAAAXDnnT9yWry6DYjLp12vIgyaSE3FMDiNhZxS6q53OpG/Hf+t+Rj UcPLWaol+zQ4FE3/zup1f9R51w== X-Google-Smtp-Source: APXvYqxW1qdIS3otqhlBBCjtCjlgjYpsGMdUHQ/sCZODIjnY3CWYaEx8TR2oCPqj2x/eeIHOuztY2Q== X-Received: by 2002:a17:902:8541:: with SMTP id d1mr5509047plo.57.1578675171031; Fri, 10 Jan 2020 08:52:51 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id s26sm3533556pfe.166.2020.01.10.08.52.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2020 08:52:50 -0800 (PST) Message-ID: <5e18abe2.1c69fb81.1ab3c.84f9@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1578486581-7540-3-git-send-email-sanm@codeaurora.org> References: <1578486581-7540-1-git-send-email-sanm@codeaurora.org> <1578486581-7540-3-git-send-email-sanm@codeaurora.org> Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Manu Gautam , Sandeep Maheswaram Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: sc7180: Remove global phy reset in QMP phy To: Andy Gross , Bjorn Andersson , Doug Anderson , Kishon Vijay Abraham I , Mark Rutland , Rob Herring , Sandeep Maheswaram From: Stephen Boyd User-Agent: alot/0.8.1 Date: Fri, 10 Jan 2020 08:52:49 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sandeep Maheswaram (2020-01-08 04:29:40) > Remove global phy reset and do only usb phy reset in QMP phy. Yes that's what this patch does, but you left out the important part: Why? >=20 > Signed-off-by: Sandeep Maheswaram > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/q= com/sc7180.dtsi > index c00c3d4..448ab88 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1072,9 +1072,8 @@ > <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>; > clock-names =3D "aux", "cfg_ahb", "ref", "com_aux= "; > =20 > - resets =3D <&gcc GCC_USB3_DP_PHY_PRIM_BCR>, > - <&gcc GCC_USB3_PHY_PRIM_BCR>; > - reset-names =3D "phy", "common"; > + resets =3D <&gcc GCC_USB3_PHY_PRIM_BCR>; > + reset-names =3D "phy"; > =20 We shouldn't need to modify the DT node for this. The reset still goes to this hardware block, so DT should reflect that. Instead, the driver shouldn't drive this reset on this SoC. > usb_1_ssphy: phy@88e9200 { > reg =3D <0 0x088e9200 0 0x128>,