From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbdJIHEf (ORCPT ); Mon, 9 Oct 2017 03:04:35 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33922 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751635AbdJIHEd (ORCPT ); Mon, 9 Oct 2017 03:04:33 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 09 Oct 2017 09:08:59 +0200 From: haver To: Julia Lawall Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, "Guilherme G. Piccoli" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] GenWQE: constify pci_error_handlers structures In-Reply-To: <1502516674-8918-3-git-send-email-Julia.Lawall@lip6.fr> References: <1502516674-8918-1-git-send-email-Julia.Lawall@lip6.fr> <1502516674-8918-3-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Roundcube Webmail/1.0.1 X-TM-AS-GCONF: 00 x-cbid: 17100907-0004-0000-0000-00001308CD36 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007865; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000235; SDB=6.00928530; UDB=6.00467297; IPR=6.00708802; BA=6.00005628; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017455; XFM=3.00000015; UTC=2017-10-09 07:04:32 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17100907-0005-0000-0000-0000846642A7 Message-Id: <5e23b4b0a5cd36df134d97c61cecb24b@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-09_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710090102 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-08-12 07:44, Julia Lawall wrote: > These pci_error_handlers structures are only stored in the err_handler > field of a pci_driver structure, and this field is declared as const. > Thus > the pci_error_handlers structures can be const too. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/misc/genwqe/card_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/genwqe/card_base.c > b/drivers/misc/genwqe/card_base.c > index 4fd21e8..8650046 100644 > --- a/drivers/misc/genwqe/card_base.c > +++ b/drivers/misc/genwqe/card_base.c > @@ -1333,7 +1333,7 @@ static int genwqe_sriov_configure(struct pci_dev > *dev, int numvfs) > return 0; > } > > -static struct pci_error_handlers genwqe_err_handler = { > +static const struct pci_error_handlers genwqe_err_handler = { > .error_detected = genwqe_err_error_detected, > .mmio_enabled = genwqe_err_result_none, > .slot_reset = genwqe_err_slot_reset, Fine with me. Thanks for the contribution. Acked-by: Frank Haverkamp