From: Stephen Boyd <swboyd@chromium.org>
To: John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v2 1/3] alarmtimer: Make alarmtimer platform device child of RTC device
Date: Tue, 21 Jan 2020 14:44:30 -0800 [thread overview]
Message-ID: <5e277ecf.1c69fb81.e60bd.1a96@mx.google.com> (raw)
In-Reply-To: <20200121194811.145644-2-swboyd@chromium.org>
Quoting Stephen Boyd (2020-01-21 11:48:09)
> @@ -115,10 +118,14 @@ static int alarmtimer_rtc_add_device(struct device *dev,
> get_device(dev);
> ws = __ws;
> __ws = NULL;
> + pdev = NULL;
> + } else {
> + ret = - 1;
^
Ick. This has an extra space.
> }
> unlock:
> spin_unlock_irqrestore(&rtcdev_lock, flags);
>
> + platform_device_unregister(pdev);
> wakeup_source_unregister(__ws);
>
> return ret;
next prev parent reply other threads:[~2020-01-21 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 19:48 [PATCH v2 0/3] Fix alarmtimer suspend failure Stephen Boyd
2020-01-21 19:48 ` [PATCH v2 1/3] alarmtimer: Make alarmtimer platform device child of RTC device Stephen Boyd
2020-01-21 22:44 ` Stephen Boyd [this message]
2020-01-21 23:43 ` Doug Anderson
2020-01-21 19:48 ` [PATCH v2 2/3] alarmtimer: Use wakeup source from alarmtimer platform device Stephen Boyd
2020-01-21 23:45 ` Doug Anderson
2020-01-21 19:48 ` [PATCH v2 3/3] alarmtimer: Always export alarmtimer_get_rtcdev() and update docs Stephen Boyd
2020-01-24 1:04 ` Thomas Gleixner
2020-01-24 1:14 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e277ecf.1c69fb81.e60bd.1a96@mx.google.com \
--to=swboyd@chromium.org \
--cc=dianders@chromium.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox