From: Ivan Safonov <insafonov@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
Soumyajit Deb <debsoumyajit100@gmail.com>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused members of struct xmit_buf
Date: Mon, 13 Jul 2020 00:11:56 +0300 [thread overview]
Message-ID: <5e3186e7-4b07-c119-2658-ebe5464a9fa7@gmail.com> (raw)
In-Reply-To: <895d5f76-832f-62a0-fc82-79b26ca104d4@lwfinger.net>
On 7/12/20 8:55 PM, Larry Finger wrote:
> On 7/12/20 7:38 AM, Ivan Safonov wrote:
>> Remove unused members of struct xmit_buf: alloc_sz, ff_hwaddr,
>> dma_transfer_addr, bpending and last.
>>
>> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
>> ---
>
> Have you tested this change? Previously with this driver, an unused
> quantity was removed from one of the structs and the driver failed.
> Apparently, the alignment of some other quantity was affected. I do not
> think that this change would have that affect; however, you should be
> testing whenever the changes are more than cosmetic.
>
> Larry
>
I have not tested this patch.
Ivan.
next prev parent reply other threads:[~2020-07-12 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 12:38 [PATCH] staging: r8188eu: remove unused members of struct xmit_buf Ivan Safonov
2020-07-12 17:55 ` Larry Finger
2020-07-12 21:11 ` Ivan Safonov [this message]
2020-07-13 13:16 ` Dan Carpenter
2020-07-13 14:23 ` Dan Carpenter
2020-07-13 18:28 ` Ivan Safonov
2020-07-13 21:15 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3186e7-4b07-c119-2658-ebe5464a9fa7@gmail.com \
--to=insafonov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=debsoumyajit100@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox