From: Rohit Sarkar <rohitsarkar5398@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
alexandru.Ardelean@analog.com, dragos.bogdan@analog.com,
Matt Ranostay <matt.ranostay@konsulko.com>
Subject: Re: [PATCH] iio: health: max30100: use generic property handler
Date: Sun, 15 Mar 2020 20:57:13 +0530 [thread overview]
Message-ID: <5e6e4954.1c69fb81.f5a45.b76d@mx.google.com> (raw)
In-Reply-To: <20200315124955.207d515c@archlinux>
On Sun, Mar 15, 2020 at 12:50:39PM +0000, Jonathan Cameron wrote:
> On Fri, 13 Mar 2020 08:59:13 +0530
> Rohit Sarkar <rohitsarkar5398@gmail.com> wrote:
>
> > Instead of of_property_read_xxx use device_property_read_xxx as it is
> > compatible with ACPI too as opposed to only device tree.
> >
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
>
> Look at how this driver is probing from DT. There is another thing you need
> to do to make it possible to use PRP001 ACPI based bindings.
>
> (check what Andy Shevchenko did in a similar patch)
>
> I'm being deliberately vague as useful for you to understand what is going
> on here for yourself :)
>
> Also, make sure to check you have cc'd everyone relevant. Here you are missing
> the driver author. +cc Matt
> Jonathan
Have sent out a v2 with the required correction, although I still dont completely
understand how this ACPI magic works. In the process of going over
https://www.kernel.org/doc/Documentation/acpi/enumeration.txt get a
better picture.
Thanks,
Rohit
next prev parent reply other threads:[~2020-03-15 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 3:29 [PATCH] iio: health: max30100: use generic property handler Rohit Sarkar
2020-03-15 12:50 ` Jonathan Cameron
2020-03-15 15:27 ` Rohit Sarkar [this message]
2020-03-16 8:08 ` Matt Ranostay
2020-03-16 11:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e6e4954.1c69fb81.f5a45.b76d@mx.google.com \
--to=rohitsarkar5398@gmail.com \
--cc=alexandru.Ardelean@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox