From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FDF014A09A for ; Thu, 13 Jun 2024 17:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718299235; cv=none; b=Xgcqw8EsxVvRCKnC1BPsChCll5oG0eLDdf/HQ6DYepmzsfu6WwHtxgo2h58/1waHAbKvBwbTs+beduhLh/nUtJT+zFFLUbM3Q7Ekp3bAmOvt43+4SA718DHjw2ODoNzBTn78iid4zgdmXX3z+JzAQgbaayUaZ/R6XVmtx14H7Lc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718299235; c=relaxed/simple; bh=vX4tZlfdMiDbAOqyzjLKdId0wIu+miOZ29FnR8jsohU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WVCMBdmFe/15aQ5fp1Fes6qq8DTL2CiLAMP1YBssgjdDfEtG6orcBmbMyU5Y4QQxZSbZdzBMiVm5iqdbgzQh7PwMV7IsgWJP1etpvtyvC9IQclEm290k/7+jJzXLoF6rLhGZ5bnpgj7xVIisIYLM2lRMO/oCwN3jay0b1+JqNBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e3iiQebH; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e3iiQebH" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2eae5b2ddd8so21214821fa.0 for ; Thu, 13 Jun 2024 10:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718299232; x=1718904032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lmCat4yFzakLoPqsICLGJKZ86qrL9CrdVXXkrAz9XWA=; b=e3iiQebHT4EK0OwiMj4owv5tcaaj3m5nUDjIFNNYwjZQcwWx/r0Y9RbNgeqjRkC/U/ nv1RMkUDeQ6jaCeIWvWS3bKpN87vLZo5G0cBOChYrBGfCDCiYpXJBU2V3qucfEaFLPks /Bla1sMan0J5Hnt5sq+FDbh3VIiFQC6jXBhg326Fn6iuulw4GQh4cCrHk+T8MUQQDZcb D4+2Mvpg+c9wZlqdFii4EwNTYk4J67fqZyCi5T4/Lq95CTzGVt3nuXbqAAc2NA8AqVDE rwI0Jv4CnqzFRB13olKxgFGoNlh8lfK/xqIaJGssOdDLPRrCrCZ/JJqxLu9gJMJG2EKo s2wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718299232; x=1718904032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lmCat4yFzakLoPqsICLGJKZ86qrL9CrdVXXkrAz9XWA=; b=fvU4YY1wPzOTsZH+Fn63yGKsxOVCIIfIHkWkCx7V1pyx3X7UuawzT9VuA7Broaqx/j GeP5uiNtpaYI2Zi4X7iHpPJcX6jc07yZnYo9aqbJ6ZhQqd2f1gegtqZ4uWfve7S8SA7H 0I4litI3t5qGDfb4PxDQ8BItxnSIcMxyRtJzlIKSth/+tIp91ghnlV9OmFaxkLx9BNix qsyKGBn16gNaLW6FBpVqa8ACgSBdm30dhtdvPKp6Xw8LhR1A9EMA1qyGbRA2GG2XHFxx 7NJdAk+moxf9V7/5+vx6bSy6atuW0+PhZx/ZKS0zqLOdXHZ2di0NCJyYyx+oYyrPmu0J SflA== X-Forwarded-Encrypted: i=1; AJvYcCX32iOL9D2U9/Ipqb4ZqctXmzFhgbWgITOrH7M9NqrPOPsYNxfuM9m6w+OSWIgsxODYWqVS8ZlC/Q6M64QMN5j6A93b0PnZxQtdweq7 X-Gm-Message-State: AOJu0Yyd2EcT/lkKYhWBFCGYnugFUtbkKCLd6zGeI67XOciOKhk9CGAK VpeH9Ew0XJwuZxWeHZCirvsdcTA39Q0PXJ6aS1Shm34dnBeN5QT6/ickjJrVd9Y= X-Google-Smtp-Source: AGHT+IE4j3HMxhLWYVU29TQZzIBVMZHRaQ5xZ54nQ/SRi+BohkpWnbIsKLlp0bKYqGHndxwko/uGhQ== X-Received: by 2002:ac2:5183:0:b0:52c:8daf:da1c with SMTP id 2adb3069b0e04-52ca6cb877emr133289e87.20.1718299232137; Thu, 13 Jun 2024 10:20:32 -0700 (PDT) Received: from ?IPV6:2a00:f41:900a:a4b1:9ab2:4d92:821a:bb76? ([2a00:f41:900a:a4b1:9ab2:4d92:821a:bb76]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca2887effsm295391e87.257.2024.06.13.10.20.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 10:20:31 -0700 (PDT) Message-ID: <5e916d38-7dce-43d7-bee0-a10842faabfe@linaro.org> Date: Thu, 13 Jun 2024 19:20:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer To: Stanislav Jakubek Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <2b39d763-5b79-4b21-85f9-22fee9f87468@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/13/24 19:18, Stanislav Jakubek wrote: > On Thu, Jun 13, 2024 at 09:48:26AM +0200, Konrad Dybcio wrote: >> >> >> On 6/9/24 13:05, Stanislav Jakubek wrote: >>> Add the accelerometer and magnetometer that are present on the Motorola >>> Moto G (2013) device. >>> >>> Signed-off-by: Stanislav Jakubek >>> --- >> >> [...] >> >>> +&blsp1_i2c2 { >> >> Consider setting a clock-frequency = <> > > Hi Konrad, > > checking downstream [1], qcom,i2c-bus-freq for I2C2 is 100000, which seems > to be the default. Should I specify it anyway? Yes, at the very least to silence the dmesg warning ;) Konrad