From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbdJOUKr (ORCPT ); Sun, 15 Oct 2017 16:10:47 -0400 Received: from mout.web.de ([217.72.192.78]:61328 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbdJOUKp (ORCPT ); Sun, 15 Oct 2017 16:10:45 -0400 Subject: [PATCH 3/3] char/bsr: Adjust one function call together with a variable assignment From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Cc: LKML References: Message-ID: <5ec5cfbe-bc03-d01a-d5e6-4083b7071d69@users.sourceforge.net> Date: Sun, 15 Oct 2017 22:10:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:dw7dQ2loIpQEwB07MNeXTV/0+NcDv3meUL2XEl2WfnVDbt7zA3P ArhhhQOhs9M+QAA+JdjfoMKG+qbmE2h8SK0s3LxAnmsWEOc+ZXNsi2j9z8ljQfpw+MT5IEj ty+BygIJZum5JL5P9XWh7dA0IlTx82yTipYQ7jbS4veSGWUaNxChBYh6NcRzPPoCIQx2aQL JwAOpvHjrz3TcZLjVXtFA== X-UI-Out-Filterresults: notjunk:1;V01:K0:FyYttLgPAjk=:c62n7fhIDX1ARLwZPIstQ5 bgkh21jc7WEuuX5SNGx+AvMBjkOES+fQBiInfcGXvDCwvjEBd+zlWr8xy+c9fY3BtC6V69bb/ KHiI47hnayZW4b4DFcOJmpCz64lZqSRUe+a+tUqKic4aej6L8/5xDz8HpP7i+D37WDTEd05Em Bi29uQzISbpE74RC8vzNMOQPiFTWuFJTvVdGTJqAZR9LrEsBbyM2ViqFU8j+8iL5L68rnl2oH /hdivm0MNEtDR96sUlgFu2gvBxI27HZYGPwtN3G2bx3avympTbKBiRYsvfcNvAI2UTzo1DCze ja+J8r9+ErZAysSpbx9LghquRuKwDH4FdFAWudYNQvOpqD1f8udw4v3VOkVW24rb4KYK3uy1v BaxAINlBfje1tTwxx6emAZCE0TFxpOFzzmufnF7bP3zMZVoS9jzBEAfO9mYIsS3ebSRgqLS0S AW7sK4veVmWWvkClbOXF9la+RyzrnB5StRfmHnViEwIymhjLffqKQBBsY2XKlxUI2eVmSWKiF Ro8F5vpecLApyqmtxpRMRaZCM4ddCv1gdi3HcV9ms+6i0bod+AevlPGq6ehz2gTCN49DfXXPM gTmTt5elitGoHE0Yc4GjcrrHWvKHP61BLdFv/YmuGZrGzJ0HARSlqK6iymxjxU/fHa5VseVnG vk+ttN8jb0g3WQD7x5bZqauOZ1PI8mGYU447XyJYPg4KnytyLFKjWBMod3+a91H5CjobBMQYZ qSg7wR2v/LvTO7HDDzl60Zjk9rbMkjGUZGID/nvyIvnfN0qD5RY1JZf9imhqBq9ornF1DKag/ SUPjy4TvQeRhIgs8Fq+TydW75Jx8zuX3UseBC1/kKahoSHmwYE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 15 Oct 2017 21:55:26 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/char/bsr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index d0597dfa4d88..f11df210294a 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c @@ -320,7 +320,8 @@ static int __init bsr_init(void) goto out_err_2; } - if ((ret = bsr_create_devs(np)) < 0) { + ret = bsr_create_devs(np); + if (ret < 0) { np = NULL; goto out_err_3; } -- 2.14.2