From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC93125AA for ; Thu, 7 May 2026 00:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778112292; cv=none; b=AGPxs73arW0b6LHgxfbO5AUFZvUDoSbC17wL/CMBp0OjKn3jfmxG5gJ/7hbhPNsCbcWc2kcnSNB9ET3MzdyN3fggqZRz0X86fJ3+E+v9YloMOoic/tIIaAQNHX5VtzlKXS44DbVFPKIQe4GzWYmxwl6Y3zJxaZxbPgM2eTPHvCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778112292; c=relaxed/simple; bh=16JQyE6Zi0Kp6GQ3lbRAjtd2h20JXLIwEYfU7LcZ6ck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GQgLPvLZp1jSzKk0/WAPfTXU6rR5Kq7mMD/N9yjOw98IpIcYtcf6sG7GkXDTjzS9nAkfpcue5lhpEJi4CRbOWeItoRqfZ2BCL/qSCD/H++U5chx16Mt2AWT/f/GV3gtFrj929uV3PG+JUElDeyH4Y6aW3npWtYSWtSw/Drr/p4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nY2JWpgT; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nY2JWpgT" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ba17c8cfacso2967685ad.2 for ; Wed, 06 May 2026 17:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778112291; x=1778717091; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xA8C4MZYJtvM8pYVZlZQizvYlQAizDIxyROzXvXV/0M=; b=nY2JWpgTmLAHO94Bj7rzJB1WHQZCdT9W7zqupz+gILiyo6JOEwtZsvDoagybwUyMic NKmF2kZpsSIymJarZdVbE16h8rMb7Ys8yWJqhxWj2DTpLRrv/QTf5qVQMwLx7K5xcbGq JNUS7fjOA0gf8ZFaQLsx7SoZLjdJXGZK4+RdUIrv+AcbAWCjhNwd0/GBSjMQ7zOcLgeF CKNyercxx82nFIKLewav1ansdlzCzo9Fb+/yCbNFgdV8nrrMlvCMq4pFfbWf8/xQ3+du PRZrQ3x+xLT98+555Eovj7O3e1N2guJvlsXH/s+AL0o/QBqjRCF9wPyTvvZxNOV0hJW5 pyXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778112291; x=1778717091; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xA8C4MZYJtvM8pYVZlZQizvYlQAizDIxyROzXvXV/0M=; b=kogh8e+rZnAJrLlC8qHQna+YnEkV26z1EJzaP/1EG2sd0pAwKkNwoVGDvNGMOP6yi/ ys9uN6wJvCZGMaLkY7hjxOxLIeid2/2AH23nhUpJj7LymqnMe3QvlVFUqmh+MIrRS9dz 1hJ0wZxh6WDvX134S3OF2OhfJBd3BDmo5xOUq0noduJWrYApd09k2tJTcC22jeHitDe3 PfO30NEDYxNyLLto+BIKPQOl7u/5uLJGeiy6+Eh1g6lAj/uhb8VPT8Zabt4fGJfjl/PZ IdiabIaFHS2C1HwZC21BiM66G2tClU8I7pisElGDhd6f0T+5WteLkEuUvG6Taj3DySEl PcnA== X-Forwarded-Encrypted: i=1; AFNElJ8Os9CImqngWVsbQd0P3svQhG4qxSwHNFwHdDeV3ROBm0lzMhXh3npRKpAuRbWmVxF2YsoiA3qNJagQgiA=@vger.kernel.org X-Gm-Message-State: AOJu0YxidX83GvVfhcZ5msbP18eo42HKa/lqS5eIPkgF5v4w3bwPCH16 27t6H7TEuNU2mtMwSr8vCbjQBGOXZy/vwEdlFOK128/c50p71DO5i4Tu X-Gm-Gg: AeBDieuoengLQjZ3HUugNVFmNe1GTZ3yFG7+hFhgDkC1pdxsma4F4gKtD1UYtrHGhKq aehc4KQZmuo6za2WCaGE2W2cp6dK8mSXtfBAFezwpwrHwuAanTHIogNv7ZkZJXxNnkqcTH9lG6G Mxn8b7OTiOXJJ1TRZRMo85Dp5lLiCFI7x09furjfd3jIEMktfGuSSJEBJVHMwQ1IFvHsEkoagYv OF0BgqtiZjyWZJctiMnuJAwHZyX6Ue0dNELFuwPfuBW7pTCMhIk9i2F3lhCBdlatwHajTKbZhyk mVy35I/+0LqtUdnDxr55FYA8WnFLY0v/+5Vkb/RykPi/MtY6ofS8cm7T2CJalVlW/6uA7Zo7P9v pQc+v3Ol3nfghccx5XnHiI58L8rCi8/VtaGFt7taTgj66/UOV0pRTqKDEzV63eOzyAhmv2UvKtR eZ9YvUTjRuXbjjwRsykzSSZud6bMS3imuQ7Nl1i5ABVBA8Qhll49pTUkN/Nw9ADQSLagRICdZNu Qi+8NA= X-Received: by 2002:a17:903:428f:b0:2b4:5f69:715d with SMTP id d9443c01a7336-2ba798d5657mr39069615ad.25.1778112291000; Wed, 06 May 2026 17:04:51 -0700 (PDT) Received: from ?IPV6:2402:f000:3:1001:8803:d9da:dac1:4a73? ([2402:f000:3:1001:8803:d9da:dac1:4a73]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baba80ac1esm4058255ad.0.2026.05.06.17.04.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 17:04:50 -0700 (PDT) Message-ID: <5ee7815e-a858-4359-881e-cf1b47242d0b@gmail.com> Date: Thu, 7 May 2026 08:04:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] tools: gpio: validate arguments in gpiotools_request_line To: Maxwell Doose Cc: linux-gpio@vger.kernel.org, brgl@kernel.org, warthog618@gmail.com, linux-kernel@vger.kernel.org References: <20260503190016.13439-1-zxl434815272@gmail.com> <20260504075036.12190-1-zxl434815272@gmail.com> <20260504075036.12190-2-zxl434815272@gmail.com> Content-Language: en-US From: 007 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit OK, I will redo it, thanks. Best regards, Zhang Xiaolei On 5/5/26 00:13, Maxwell Doose wrote: > On Mon, May 4, 2026 at 2:56 AM Zhang Xiaolei wrote: >> Add validation for input pointers and number of lines. >> > Perhaps make the commit message more descriptive? > >> Signed-off-by: Zhang Xiaolei >> --- >> tools/gpio/gpio-utils.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c >> index 176bccfcccb0..930a38fe7911 100644 >> --- a/tools/gpio/gpio-utils.c >> +++ b/tools/gpio/gpio-utils.c >> @@ -65,6 +65,12 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines, >> int i; >> int ret; >> >> + if (!device_name || !lines || !config || !consumer || !num_lines) >> + return -EINVAL; >> + >> + if (num_lines > GPIO_V2_LINES_MAX) >> + return -EINVAL; >> + > I'm wondering if we might want to use ERANGE here for the num_lines > > GPIO_V2_LINES_MAX check instead of EINVAL. > > best regards, > maxwell