From: Joel Fernandes <joelagnelf@nvidia.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
linux-pci@vger.kernel.org, dakr@kernel.org, acourbot@nvidia.com,
"Alistair Popple" <apopple@nvidia.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"John Hubbard" <jhubbard@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
joel@joelfernandes.org,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>
Subject: Re: [PATCH v2] rust: pci: Allocate and manage PCI interrupt vectors
Date: Fri, 3 Oct 2025 15:20:24 -0400 [thread overview]
Message-ID: <5f01316b-e685-49fe-b2b1-270c3ff84e5a@nvidia.com> (raw)
In-Reply-To: <20251003173324.GA361946@bhelgaas>
On 10/3/2025 1:33 PM, Bjorn Helgaas wrote:
> On Thu, Oct 02, 2025 at 02:39:12PM -0400, Joel Fernandes wrote:
>> Add support to PCI rust module to allocate, free and manage IRQ vectors.
>> Integrate with devres for managing the allocated resources.
>
>> +/// IRQ type flags for PCI interrupt allocation.
>> +#[derive(Debug, Clone, Copy)]
>> +pub enum IrqType {
>> + /// Legacy INTx interrupts
>> + Legacy,
>
> FWIW, when I can, I try to use "INTx" instead of "legacy" because
> "INTx" has a specific meaning and is used in the PCIe specs, while
> "legacy" by itself has no intrinsic meaning.
>
Sure, I will avoid using the word legacy for naming. thanks,
- Joel
next prev parent reply other threads:[~2025-10-03 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 18:39 [PATCH v2] rust: pci: Allocate and manage PCI interrupt vectors Joel Fernandes
2025-10-03 17:33 ` Bjorn Helgaas
2025-10-03 19:20 ` Joel Fernandes [this message]
2025-10-05 12:56 ` Danilo Krummrich
2025-10-08 18:11 ` Joel Fernandes
2025-10-08 18:45 ` Joel Fernandes
2025-10-08 19:09 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f01316b-e685-49fe-b2b1-270c3ff84e5a@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=joel@joelfernandes.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox