From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1310C433DF for ; Sat, 18 Jul 2020 14:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9587E2070E for ; Sat, 18 Jul 2020 14:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727090AbgGROR7 (ORCPT ); Sat, 18 Jul 2020 10:17:59 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:38127 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726574AbgGROR6 (ORCPT ); Sat, 18 Jul 2020 10:17:58 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R351e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01358;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0U33fhOh_1595081868; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U33fhOh_1595081868) by smtp.aliyun-inc.com(127.0.0.1); Sat, 18 Jul 2020 22:17:49 +0800 Subject: Re: [PATCH v16 21/22] mm/pgdat: remove pgdat lru_lock To: Alexander Duyck Cc: Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Matthew Wilcox , Johannes Weiner , kbuild test robot , linux-mm , LKML , cgroups@vger.kernel.org, Shakeel Butt , Joonsoo Kim , Wei Yang , "Kirill A. Shutemov" References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-22-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: <5f162d78-2318-3d12-bbbb-1a47ed978bf7@linux.alibaba.com> Date: Sat, 18 Jul 2020 22:17:48 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/7/18 上午5:09, Alexander Duyck 写道: >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index e028b87ce294..4d7df42b32d6 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6721,7 +6721,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) >> init_waitqueue_head(&pgdat->pfmemalloc_wait); >> >> pgdat_page_ext_init(pgdat); >> - spin_lock_init(&pgdat->lru_lock); >> lruvec_init(&pgdat->__lruvec); >> } >> > This patch would probably make more sense as part of patch 18 since > you removed all of the users of this field there. yes, I just want to a bit of sense of ceremony to remove this huge big lock. :)