* [PATCH v2 net-next] net: udp: remove redundant initialization in udp_gro_complete
@ 2020-11-10 2:57 menglong8.dong
2020-11-12 22:47 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: menglong8.dong @ 2020-11-10 2:57 UTC (permalink / raw)
To: kuba; +Cc: davem, kuznet, yoshfuji, netdev, linux-kernel, Menglong Dong
From: Menglong Dong <dong.menglong@zte.com.cn>
The initialization for 'err' with '-ENOSYS' is redundant and
can be removed, as it is updated soon and not used.
Changes since v1:
- Move the err declaration below struct sock *sk
Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
---
net/ipv4/udp_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
index b8b1fde..54c9533 100644
--- a/net/ipv4/udp_offload.c
+++ b/net/ipv4/udp_offload.c
@@ -554,8 +554,8 @@ int udp_gro_complete(struct sk_buff *skb, int nhoff,
{
__be16 newlen = htons(skb->len - nhoff);
struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
- int err = -ENOSYS;
struct sock *sk;
+ int err;
uh->len = newlen;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 net-next] net: udp: remove redundant initialization in udp_gro_complete
2020-11-10 2:57 [PATCH v2 net-next] net: udp: remove redundant initialization in udp_gro_complete menglong8.dong
@ 2020-11-12 22:47 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-11-12 22:47 UTC (permalink / raw)
To: menglong8.dong
Cc: davem, kuznet, yoshfuji, netdev, linux-kernel, Menglong Dong
On Mon, 9 Nov 2020 21:57:58 -0500 menglong8.dong@gmail.com wrote:
> From: Menglong Dong <dong.menglong@zte.com.cn>
>
> The initialization for 'err' with '-ENOSYS' is redundant and
> can be removed, as it is updated soon and not used.
>
> Changes since v1:
> - Move the err declaration below struct sock *sk
>
> Signed-off-by: Menglong Dong <dong.menglong@zte.com.cn>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-10 2:57 [PATCH v2 net-next] net: udp: remove redundant initialization in udp_gro_complete menglong8.dong
2020-11-12 22:47 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).