From: Ganesh Venkatesan <ganesh.venkatesan@gmail.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "David S.Miller" <davem@davemloft.net>,
christoph@lameter.com, akpm@osdl.org,
linux-kernel@vger.kernel.org, "Venkatesan,
Ganesh" <ganesh.venkatesan@intel.com>
Subject: Re: [RFC][PATCH] timers fixes/improvements
Date: Thu, 12 May 2005 16:36:23 -0700 [thread overview]
Message-ID: <5fc59ff305051216367e3054cd@mail.gmail.com> (raw)
In-Reply-To: <42821F65.3FEA7939@tv-sign.ru>
John Linville, who originally proposed the patch (to add
e1000_watchdog_task and related code) has since withdrawn the patch.
e1000_down may still be suffering from the del_timer_sync race
condition that Oleg identified at the start of this thread.
ganesh.
On 5/11/05, Oleg Nesterov <oleg@tv-sign.ru> wrote:
> Btw, i think that drivers/net/e1000/e1000_main.c:e1000_down() is buggy.
>
> It calls del_timer_sync(&adapter->watchdog_timer), but e1000_watchdog()
> calls schedule_work(e1000_watchdog_task), so the work could be queued
> after del_timer_sync().
>
> And e1000_watchdog_task() arms timers again.
>
> Note that it's not enough to do flush_scheduled_work() here.
>
> Oleg.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2005-05-12 23:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-01 11:57 [RFC][PATCH] timers fixes/improvements Oleg Nesterov
2005-04-01 11:59 ` Oleg Nesterov
2005-04-01 13:07 ` Ingo Molnar
2005-04-01 13:52 ` Oleg Nesterov
2005-04-01 12:58 ` Ingo Molnar
2005-04-01 16:08 ` Linus Torvalds
2005-04-01 18:32 ` Andrew Morton
2005-04-01 18:41 ` Christoph Lameter
2005-04-01 18:44 ` Chen, Kenneth W
2005-04-02 9:22 ` Oleg Nesterov
2005-05-09 20:35 ` Christoph Lameter
2005-05-09 21:42 ` Andrew Morton
2005-05-09 21:51 ` Christoph Lameter
2005-05-10 10:23 ` Oleg Nesterov
2005-05-10 19:15 ` Christoph Lameter
2005-05-10 21:48 ` George Anzinger
2005-05-11 10:18 ` Oleg Nesterov
2005-05-11 15:12 ` Christoph Lameter
2005-05-13 22:36 ` Greg KH
[not found] ` <20050510.125301.59655362.davem@davemloft.net>
2005-05-11 15:06 ` Oleg Nesterov
2005-05-12 23:36 ` Ganesh Venkatesan [this message]
2005-05-09 23:10 ` Christoph Lameter
2005-04-02 10:07 ` Andrew Morton
2005-04-02 11:02 ` Oleg Nesterov
2005-04-02 14:58 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2005-05-17 15:38 Sy, Dely L
2005-05-17 15:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc59ff305051216367e3054cd@mail.gmail.com \
--to=ganesh.venkatesan@gmail.com \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=davem@davemloft.net \
--cc=ganesh.venkatesan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox