From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47716313E0C for ; Mon, 1 Dec 2025 15:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764601613; cv=none; b=qjzgG8SiieNZQC9TY2gHmMZmQRQ2tAtB2Y25dyzWEs5WihnVjAXFY69QLUrsAD4FPzYWQuIA7A+4Ns5jnIRm7FKWirr3Ds2w6oPGJ+b4qS95AF5WjvzdODFVWeJPkPoMXvVQTe4ZPVE2sdJ9x6Wbm8OJIswDZdb/Ycmm9Rtgfpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764601613; c=relaxed/simple; bh=PThqKDlMOg91G9eF992kfltVjOsaxU5dxzmEfM1kCN8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hOUQVdC7F/cek7U3Bh2PYU961wbW8W6E6tKblpuMef9hWgm54T1yyavW6Wqm2xBa4lM1ufF3Agytylf5auM8DFce9uS202o95uOfMQFraah3a9N6wBGDz/SqBwpI6CA9uaJO5MHHQTzIKhiZcQfOx8vJCmO1Xx1l80BA2xdB+HM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o4h1g+m7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dfM0FPEg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o4h1g+m7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dfM0FPEg" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B1A8ICH436304 for ; Mon, 1 Dec 2025 15:06:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WN31XpVKAWNLpUrQxWKBO3fZgfcxLv8M2+uJRSw2WAM=; b=o4h1g+m79D7Y/C54 /8ZiqwNjYEJmcnVRZaLzNf0rbmcjOw3pnb+n5xhqwxJp/0QHfCnnRtrTeEfHNAfL GG+T0vRr9AzUjtIiBBCDiQYZLOatwFOD0iU6qxD+GkJKM7UsEsu5Fp0+3ekIz6jD O0biRBwYPpNEjA5+7SxvI6OBrVgGDMPvU9ShJw0KxRzQt9fD7stNzqFy5T6j23qQ dkNFjdhu5R2kh3L23INdaZtgB9j7nmb/Ox3B2OsArnq/Cciu5+OwUbAD7MExH+kH DVxrjxv+Yp14sHeOvM8eoi+g+MKAQen3qMBY9oQ+AYOkR3llaLs9fVlOwksLSsbf Tw9fuQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4as909rt0d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 15:06:50 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5dfb8e7d182so531494137.1 for ; Mon, 01 Dec 2025 07:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764601610; x=1765206410; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WN31XpVKAWNLpUrQxWKBO3fZgfcxLv8M2+uJRSw2WAM=; b=dfM0FPEgXFGvgY4y6yJ7slzXjywSDSTNLRHUC9soJlCdV9x1pgAkCZIowuhCB/VNPW wtwnxceMfjBSl7HQpvmTC7rFDEOqCacnnTCZmgv54FqETfXSG5IecQ77V1JIAYCHYTtd HUIwZ8W+q7zK5k3DW6U+drk3Bo6XioHOajWeBBAKDOK7wPs2gi7Uoj1JNlam3unhxp7e NlzgKRXbaKspBk2s7UDUOoAJROLwBC+sXkczEQVGZhUIyM7enOIfryv/Ksv7QcXTqd5Y seETnn4cblU/0isdz6+GsbypwCIfeRKe3a9DJNRGNYUy3INlBwOTCxY+7I2j4xNimZdM 9D5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764601610; x=1765206410; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WN31XpVKAWNLpUrQxWKBO3fZgfcxLv8M2+uJRSw2WAM=; b=pVlNAw5zOB3IWom31Z8tQJWvAaMjkcXUyara5QisTZdvsMGHPGXPLulrUOVY+TaD+7 EisdFWruYani3Dq1MuSADYJte2UyuLVMJsA6N5EmatE9FXXnATfU2voIODrdb2pNIqoa 9Z+LnaHT3jjPfI5j7lg+fVDTB4JCd6lIkiHLX9Gd1//58kriRRxBA1Ain32yTcIxHVNr vAnRHbW6QFPuffuE68bfJP3Teu9H5O/9LyjylefITafPcgk6qHWmFjmzLWzWPpcAgYdM 9pLFwgC7uc25CWohMImP7Si3M8C6FBfwp9eqUerZDXcPERGOpJ9ujpir4uF5IbNdt3Q0 HKDw== X-Forwarded-Encrypted: i=1; AJvYcCWasEpIlAv87U2iNnQKxEpaHgAk+Ie+kBCxwiagDjPQAsTkD+h/NAP7EKaJjtwc+kgh1ZSFRz6ZNe4c7mY=@vger.kernel.org X-Gm-Message-State: AOJu0YyoMi34yI2HuwQPLfuJVhqEHQebzsEkd+qD3JfuieNj7al3RD3M I/TMJxOcUnefyo7D1X+6Ub5vmlq3lZeXA2mhNvpyCgv6qguHNTBPW1QrYm+EFpl6VtePWXrCpzC npr2C8wsFKWDj8pych/qPvqu0kFl8tVOzz8q8TdysdFLCovKjeIIh+hMPl5OQDfTqjk8= X-Gm-Gg: ASbGncsZeOvJw96BlKDl8E/KuZlRon2xYk7O5E/+bQQ3PJelryR8rGFVKVJFEWPJUp2 SgWVAa4/OsYZfw3CC9eBfgmaPJ2RoWbsR6yhHklWEP6g/i32bnVEvHlVysVGyrhJ246ZxHQeZ2g f3qHI1pOd6zGuM3va25l1AZfiuGkYdVC+haKP5PLWYPOL1AnVuJSFbbeNu5151EiyQXJA/ffxgJ D8iedXutY2F3hDvCvpmlR854aNirVnzN1Zl+f2nC+qZPd7y/OX+QEu20iAkaxIKWuRGCkZ5njKn 3MgGEhMSZyAXCH+34b1+TvVrIk7zowBk7rw7Ek0ydAAl7w+oW27ol/TiJqApHAxRSP6Q0kBGNDv jbI+Di1wikBm8CUzdFC7hP/4giNe1Bqyp5kjWjwnfZT7I05n/ux086x01IwcunBOMx58= X-Received: by 2002:a05:6102:dd2:b0:5dd:c3ec:b76 with SMTP id ada2fe7eead31-5e1e66f4505mr8267348137.1.1764601609978; Mon, 01 Dec 2025 07:06:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfVlN7RdzDAkpjv08QNbaMbaegno0fcNkNHVYzQ7+oy8pVcRZH27l0E3h3aEvMozx/stlEug== X-Received: by 2002:a05:6102:dd2:b0:5dd:c3ec:b76 with SMTP id ada2fe7eead31-5e1e66f4505mr8267225137.1.1764601608838; Mon, 01 Dec 2025 07:06:48 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59e93c4sm1215866966b.53.2025.12.01.07.06.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 07:06:48 -0800 (PST) Message-ID: <5fcfbd5a-bd08-4549-9846-29c3da888a84@oss.qualcomm.com> Date: Mon, 1 Dec 2025 16:06:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] interconnect: qcom: qcs8300: enable QoS configuration To: Odelu Kukatla , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Dmitry Baryshkov , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20251128150106.13849-1-odelu.kukatla@oss.qualcomm.com> <20251128150106.13849-3-odelu.kukatla@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251128150106.13849-3-odelu.kukatla@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEyMyBTYWx0ZWRfX9F4nQFP+Y5tl yKBVIxiuSsHxgMKODIAAUcbbumfQT4BDxTxflsm5ugfa0ZlcBNYTi+eGYzDJDvh774xCDYx0okI wUMmX+pnkHPOB56gfpPCk+ARR67vUnpyHFhM8kNvrqaee2BnwQk0EBlwswr0NkGsl+jZNAS15Er q17/1kMt+7oKE9w/JNaKg4SG4H/6o0qfM3mB8R/KZyQcAwxcBhBXlTSwhbgc+4jYcfnKJKjPzoI 4g2oSIvR6S0W1iNkx9HS/uBLXAhToUnCa01IopYc8uHmM/6bs7SW6FtahNxbEUD8dy0LO7mFvqI FvjafCwIBwHrzmmWyiv7zRg61455PBkX7S5h9kNwUuQCKnTbYckxv5nazQCoeHeqgs6OobKFsLO nlz/aiMyTUaFbbRUrcP+hpg6cOAUow== X-Authority-Analysis: v=2.4 cv=XJQ9iAhE c=1 sm=1 tr=0 ts=692daf0a cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=mjAHdMWAtFLaYi06n1EA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-ORIG-GUID: Ueus1XhfIMnQ1ta0_PnrG9-qcwLg9XQm X-Proofpoint-GUID: Ueus1XhfIMnQ1ta0_PnrG9-qcwLg9XQm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010123 On 11/28/25 4:01 PM, Odelu Kukatla wrote: > Enable QoS configuration for master ports with predefined priority > and urgency forwarding. > > Signed-off-by: Odelu Kukatla > --- > drivers/interconnect/qcom/qcs8300.c | 375 ++++++++++++++++++++++++++++ > 1 file changed, 375 insertions(+) > > diff --git a/drivers/interconnect/qcom/qcs8300.c b/drivers/interconnect/qcom/qcs8300.c > index 70a377bbcf29..3f4fe62148d3 100644 > --- a/drivers/interconnect/qcom/qcs8300.c > +++ b/drivers/interconnect/qcom/qcs8300.c > @@ -186,6 +186,13 @@ static struct qcom_icc_node qxm_qup3 = { > .name = "qxm_qup3", > .channels = 1, > .buswidth = 8, > + .qosbox = &(const struct qcom_icc_qosbox) { > + .num_ports = 1, > + .port_offsets = { 0x11000 }, > + .prio_fwd_disable = 1, > + .prio = 2, > + .urg_fwd = 0, FWIW prio_fwd_disable and urg_uwd are booleans, so true/false would be neat I checked a couple nodes and things seem alright, hopefully the .max_register values you set don't clip anything Reviewed-by: Konrad Dybcio Konrad