From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18AC7C433E0 for ; Thu, 31 Dec 2020 09:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB5F222262 for ; Thu, 31 Dec 2020 09:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726520AbgLaJJN (ORCPT ); Thu, 31 Dec 2020 04:09:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726218AbgLaJJL (ORCPT ); Thu, 31 Dec 2020 04:09:11 -0500 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3EE5C061573 for ; Thu, 31 Dec 2020 01:08:30 -0800 (PST) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1kutwa-00AtqB-5J for linux-kernel@vger.kernel.org; Thu, 31 Dec 2020 10:08:28 +0100 Received: from [2a02:578:460c:1:a555:6f6b:beff:dc54] by yawp.biot.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1kutwa-00Atq6-15; Thu, 31 Dec 2020 10:08:28 +0100 Subject: Re: [PATCH RESEND v2 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller To: Mark Brown Cc: Rob Herring , Birger Koblitz , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201229231904.2558916-1-bert@biot.com> <20201230135156.GF4428@sirena.org.uk> From: Bert Vermeulen Message-ID: <5fdb1361-3e12-9c44-d570-7e8404db4f17@biot.com> Date: Thu, 31 Dec 2020 10:08:27 +0100 MIME-Version: 1.0 In-Reply-To: <20201230135156.GF4428@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/30/20 2:51 PM, Mark Brown wrote: > On Wed, Dec 30, 2020 at 12:19:03AM +0100, Bert Vermeulen wrote: > >> +properties: >> + compatible: >> + const: realtek,spi > > It is possibled Realtek might make other SPI controllers, there should > be some more specific name such as a compatible for each SoC that the > controller appears in or an IP name if one is known. Mark, Good call. We're changing all the Realtek RTL838x/RTL839x stuff to some variation of "realtek-rtl", in this case "realtek,rtl-spi". The "rtl" prefix to Realtek SoCs fits the bill. Will resubmit. -- Bert Vermeulen bert@biot.com