From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marcelo Schmitt <marcelo.schmitt@analog.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
marcelo.schmitt1@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: iio: adc: adi,ad4000: Add PulSAR
Date: Wed, 20 Nov 2024 09:14:47 +0100 [thread overview]
Message-ID: <5kz6ghe56yiprlvhyduv7olcrajvejyvulcpjav6doiyvr6dcl@6qlt4nebp4gb> (raw)
In-Reply-To: <dd7fd54585e1230d2da86b5e3d4ed770256b0af2.1732020224.git.marcelo.schmitt@analog.com>
On Tue, Nov 19, 2024 at 09:53:40AM -0300, Marcelo Schmitt wrote:
> Extend the AD4000 series device tree documentation to also describe
> PulSAR devices.
>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
> ---
> No changes from v2 -> v3.
>
> .../bindings/iio/adc/adi,ad4000.yaml | 71 +++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> index e413a9d8d2a2..4dbb3d2876f9 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> @@ -19,6 +19,20 @@ description: |
> https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf
> https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf
> https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7685.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7686.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7687.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7688.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7690.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7691.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7693.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7942.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7946.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7980.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7982.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7983.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7984.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7988-1_7988-5.pdf
>
> $ref: /schemas/spi/spi-peripheral-props.yaml#
>
> @@ -63,6 +77,37 @@ properties:
>
> - const: adi,adaq4003
>
> + - const: adi,ad7946
All such cases are just one enum. That's the preferred syntax.
> + - items:
> + - enum:
> + - adi,ad7942
> + - const: adi,ad7946
> +
> + - const: adi,ad7983
> + - items:
> + - enum:
> + - adi,ad7980
> + - adi,ad7988-5
> + - adi,ad7686
> + - adi,ad7685
Keep alphabetical order.
> + - adi,ad7988-1
> + - const: adi,ad7983
> +
> + - const: adi,ad7688
> + - items:
> + - enum:
> + - adi,ad7693
> + - adi,ad7687
> + - const: adi,ad7688
> +
> + - const: adi,ad7984
> + - items:
> + - enum:
> + - adi,ad7982
> + - adi,ad7690
> + - adi,ad7691
> + - const: adi,ad7984
> +
> reg:
> maxItems: 1
>
> @@ -133,6 +178,32 @@ required:
> - ref-supply
>
> allOf:
> + # Single-channel PulSAR devices have SDI either tied to VIO, GND, or host CS.
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - adi,ad7685
Why do you need this? It's fallback is already here.
> + - adi,ad7686
> + - adi,ad7687
> + - adi,ad7688
> + - adi,ad7690
> + - adi,ad7691
> + - adi,ad7693
> + - adi,ad7942
> + - adi,ad7946
> + - adi,ad7980
> + - adi,ad7982
> + - adi,ad7983
> + - adi,ad7984
> + - adi,ad7988-1
> + - adi,ad7988-5
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-20 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 12:53 [PATCH v3 0/4] Timestamp and PulSAR support for ad4000 Marcelo Schmitt
2024-11-19 12:53 ` [PATCH v3 1/4] dt-bindings: iio: adc: adi,ad4000: Add PulSAR Marcelo Schmitt
2024-11-20 8:14 ` Krzysztof Kozlowski [this message]
2024-11-19 12:53 ` [PATCH v3 2/4] iio: adc: ad4000: Add timestamp channel Marcelo Schmitt
2024-11-19 12:54 ` [PATCH v3 3/4] iio: adc: ad4000: Use device specific timing for SPI transfers Marcelo Schmitt
2024-11-19 12:54 ` [PATCH v3 4/4] iio: adc: ad4000: Add support for PulSAR devices Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5kz6ghe56yiprlvhyduv7olcrajvejyvulcpjav6doiyvr6dcl@6qlt4nebp4gb \
--to=krzk@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox