From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE7042CB0E for ; Thu, 9 Jul 2026 15:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612526; cv=none; b=U2eDHGchepifmkprp80PTy+1tFGBamj47grnDPBSNv4zieQejeIqtCMgYA/ulkVAREWyGbXsVxxbu8eu8zXvC0G8K9ARxMQ0HpE4xuGjhwjn67Iss4QJTIUjLpYzbx5XrtGtCdgVfyTY/13wRt38yA1FA432o+ZFKnO120Z4VdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612526; c=relaxed/simple; bh=wCyya2sd3Nbuy5zuy6zvw9VrcqtHtZYtc/26a/Pi/PY=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=Iz32YBRt3HK5TYwrIoXm7ftwYKedKSfM3c2qhl9YDCAaZYqMYVPSLABMKyJN2/3WnpUBKnEWtgEZoWUldlH3GYqk6Vbsf+hq+/tIsXCLUWkQqMsikxNAq9PtMWXlj5z4sonTKuL+vuNCR5iuK1i++sZNc1z5O24ovh7ndFx9WR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LuPiNdGC; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LuPiNdGC" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso93976a91.1 for ; Thu, 09 Jul 2026 08:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783612524; x=1784217324; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=wCyya2sd3Nbuy5zuy6zvw9VrcqtHtZYtc/26a/Pi/PY=; b=LuPiNdGCeFj0A8aw4gEx4AmlvKBLKg3k6+p4k6UgzxfqVblow6FFwalnYlfxb0RaGS 7yRolobCApim7ruz00hvcooQ8UOaHYaVi8psFF2w5Aw4+mam+x/eXxz6kCezYB3ISZl3 iGiN9e0oBDHwuxu2qWjTPKxfHnbynF5wjKNL0h6lfP+NQCQkq7i5NFAYMJYSmFOi7B0e EJ+jezkeguDZmzNmAiaus7CpQ5w4kDL5NhTrrhlsmg3mc/CyWKt0m+ic14gfUMHMPdxA yu9aOYK6lri5yv2LOFv0xNmvpHMd40selPjL7XK4Z2lZa8CPA2Mdo9EOMZfbKNLRpMuW 4Tvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612524; x=1784217324; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wCyya2sd3Nbuy5zuy6zvw9VrcqtHtZYtc/26a/Pi/PY=; b=FTfFkui/l679E/m+aFwGEzh1g+oDTaL6qzzRKtWeNV+lJnCA3O2LxgVfKpWD9M59hh 88T7w92q2GIBuboefXy1GeAWD+/Zh740F4Bfc0KydQQWTyAwyV/nZ3zjBD2SD2EKJ5i9 cDToxJlYQgzsbfp4tGzlTUOjV18nsBHMHgMSLbQXkSAOFCooc8hyjRfpO+ycZeWZ2JLv x7woOFb/cpkJii0EWtJ+PBpBnM6znq6Ed1+hKaRzWttDwq+Jgng0KC1daxHG7Op++7rc tviN30iE8+sGTbIblmpZETlQpsItW412fRxA6QsBtr0pETsINqlslJXI/laUGkvc5CPX u4VA== X-Forwarded-Encrypted: i=1; AHgh+RoCZ2qPcPQAyo8tzJGiLtvDGNYQ0D7FqJlJJ0FpuuvO3UytkfPwiUiX/pSOg38tVy39iPYf4bQn8/qyN/M=@vger.kernel.org X-Gm-Message-State: AOJu0YymJtvskTv++tf0+FEQLdwKBjHjr2+dca+DBcpKtVrv1MDNnm5I m5a+eRpSMcFwkluyoFLvXU6md3ozrw3GrI4qh/PtpphkkmowPtm8wL2segxJcwVe X-Gm-Gg: AfdE7clHE2OPPBW/+1V1bc0PscsXPdtTVf3aH8WBkirGof9jKo9ZHjrHOu4fcXDfSgs tAP+w12R4I27TwU6TetiFeaxu9QONBwfv3dXUG/cbU787gz2pMCpzdINSA55uY8zwz1A7awAPp4 hyNTvFWtXRHvmpJYLydOXA49uHxnWyJ7MBfaHUXJV/Eh9Bjh0003DmU9XiNdUxmD5RpSYo+uNyc FsuCtAFdlubaX57QR9Rka/fjMKYOry4KJdhnP1qImi2+RGI78yUBrBUvjNWM07UduAro9cZoSv3 LLgLOORdUs3KjX4mQc70fYIV5XClBG7mA8rKX4fLFn2q0Fu7Qd7f+6wzpSHtCRqBnXl2B7XgI5j CXwWujf0IAOJnTHTNkaUm5E6RnCJVdDD5GTe/o2/gd1VqwGHoIwnqyKoaa+L8Le4ReeP8s1SNId XAoXUhPxJ0Teo= X-Received: by 2002:a17:90b:2641:b0:387:e0db:3fab with SMTP id 98e67ed59e1d1-389424990fbmr8089510a91.36.1783612524554; Thu, 09 Jul 2026 08:55:24 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311b00048a3sm2489614eec.5.2026.07.09.08.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:55:23 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sourabh Jain , linuxppc-dev@lists.ozlabs.org Cc: Sourabh Jain , Aditya Gupta , "Christophe Leroy (CS GROUP)" , Hari Bathini , Madhavan Srinivasan , Mahesh Salgaonkar , Michael Ellerman , Nicholas Piggin , Shivang Upadhyay , Venkat Rao Bagalkote , linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/prom: Remove redundant early_init_dt_scan_root() call In-Reply-To: <20260418091250.134111-1-sourabhjain@linux.ibm.com> Date: Thu, 09 Jul 2026 21:24:02 +0530 Message-ID: <5x2ow44l.ritesh.list@gmail.com> References: <20260418091250.134111-1-sourabhjain@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Sourabh Jain writes: > Commit 554b66233623 ("of/fdt: Scan the root node properties earlier") > moved the invocation of early_init_dt_scan_root() into > early_init_dt_verify(). > > early_init_devtree() already calls early_init_dt_verify(), so the root > node properties are parsed before reaching the explicit call in this > function. > > Keeping the call here results in scanning the root node twice. Remove > the redundant call and rely on the invocation from > early_init_dt_verify(). > > This change keeps the behavior the same and removes an unnecessary > duplicate call. > yup. Nice catch! LGTM. Feel free to add: Reviewed-by: Ritesh Harjani (IBM)