The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Fenghua Yu <fenghuay@nvidia.com>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	Peter Newman <peternewman@google.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	"Drew Fustini" <dfustini@baylibre.com>,
	Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
	David E Box <david.e.box@intel.com>, <x86@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>
Subject: Re: [PATCH v10 08/17] x86/resctrl: Enforce system RMID limit on AET event groups
Date: Fri, 21 Aug 2026 09:10:02 -0700	[thread overview]
Message-ID: <600c656c-4b62-4de1-ade0-149804e4494c@intel.com> (raw)
In-Reply-To: <aoeLm3LqYXTrADeA@agluck-desk3>

Hi Tony,

On 8/20/26 4:19 PM, Luck, Tony wrote:
> On Thu, Aug 20, 2026 at 03:28:18PM -0700, Reinette Chatre wrote:

>>
>> Thinking about this more ... does resctrl really need these to be arch helpers? With
>> the mon_capable/alloc_capable available, resctrl fs does not need any help from architecture
>> to learn whether a resource is monitor or alloc capable, no?
> 
> x86 and mpam versions of these currently use different iterator functions to walk over all
> resources. But there is a file system version in <linux/resctrl.h> so we
> could do
> 
> static inline bool resctrl_alloc_capable(void)
> {
> 	struct rdt_resource *r;
> 
> 	for_each_rdt_resource(r)
> 		if ((r)->alloc_capable)
> 			return true;
> 	return false;
> }
> 
> Ditto with s/alloc/mon/ for the matching partner,
> 
> Would you like a patch to replace the arch versions woven into this series?
> 
I see this as nice to have but I think it will require more planning than just
weaving it into this series. As you highlight this change will span the architecture
code and now there is also RISC-V to consider. I believe RISC-V is queued for inclusion
but not yet merged and it handles its resctrl_arch_alloc_capable() helper differently.

To me this thus looks more like a separate refactor that will span resctrl fs and all
the architectures.

If you find removing these helpers would help your AET dependency work then the answer is
clear whether it should be done. If it is not required then I do not think it is reasonable
to require this change as part of this AET work and I'll leave it up to you whether you want
to take it on.

Reinette



  reply	other threads:[~2026-08-21 16:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 17:27 [PATCH v10 00/17] Allow AET to use PMT as loadable module Tony Luck
2026-07-29 17:27 ` [PATCH v10 01/17] x86/resctrl: Fix enumeration of number of supported RMIDs Tony Luck
2026-08-13 23:55   ` Reinette Chatre
2026-08-14 16:28     ` Luck, Tony
2026-07-29 17:27 ` [PATCH v10 02/17] x86/resctrl: Require 64-bit x86 for resctrl support Tony Luck
2026-08-18  0:50   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 03/17] fs/resctrl: Remove redundant calls to resctrl_arch_mon_capable() Tony Luck
2026-08-18  0:50   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 04/17] x86/resctrl: Honor rdt=perf option to force enable AET perf events Tony Luck
2026-08-18  0:51   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 05/17] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-08-18  0:51   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 06/17] x86/resctrl: Drop global 'rdt_mon_capable' flag Tony Luck
2026-08-18  0:54   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 07/17] arm,x86,fs/resctrl: Handle change in number of RMIDs on each mount Tony Luck
2026-08-18  0:56   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 08/17] x86/resctrl: Enforce system RMID limit on AET event groups Tony Luck
2026-08-18  0:58   ` Reinette Chatre
2026-08-20 18:42     ` Luck, Tony
2026-08-20 21:55       ` Reinette Chatre
2026-08-20 22:28         ` Reinette Chatre
2026-08-20 23:19           ` Luck, Tony
2026-08-21 16:10             ` Reinette Chatre [this message]
2026-07-29 17:27 ` [PATCH v10 09/17] x86/resctrl: Add PMT registration API for AET enumeration callbacks Tony Luck
2026-08-18  0:59   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 10/17] platform/x86/intel/pmt: Register enumeration functions with resctrl Tony Luck
2026-07-29 17:27 ` [PATCH v10 11/17] arm,x86/resctrl: Resolve INTEL_PMT_TELEMETRY symbols at runtime Tony Luck
2026-08-18  0:59   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 12/17] x86/resctrl: Prepare to handle nested mount requests Tony Luck
2026-08-18  1:01   ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 13/17] fs/resctrl: Call architecture hooks for every mount/unmount Tony Luck
2026-08-18  1:02   ` Reinette Chatre
2026-08-18 18:20     ` Luck, Tony
2026-08-18 22:12       ` Reinette Chatre
2026-07-29 17:27 ` [PATCH v10 14/17] x86/resctrl: Export interface to report telemetry unbind/remove Tony Luck
2026-08-18 15:38   ` Reinette Chatre
2026-08-18 17:32     ` Luck, Tony
2026-07-29 17:27 ` [PATCH v10 15/17] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed Tony Luck
2026-07-29 17:27 ` [PATCH v10 16/17] x86/resctrl: Simplify Kconfig options for resctrl Tony Luck
2026-07-29 17:27 ` [PATCH v10 17/17] Documentation/filesystems/resctrl: Document telemetry mount timing caveat Tony Luck
2026-07-29 20:11 ` [PATCH v10 00/17] Allow AET to use PMT as loadable module Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=600c656c-4b62-4de1-ade0-149804e4494c@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=david.e.box@intel.com \
    --cc=dfustini@baylibre.com \
    --cc=fenghuay@nvidia.com \
    --cc=hch@infradead.org \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=patches@lists.linux.dev \
    --cc=peternewman@google.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox