From: Yonghong Song <yonghong.song@linux.dev>
To: Yuran Pereira <yuran.pereira@hotmail.com>, bpf@vger.kernel.org
Cc: sinquersw@gmail.com, ast@kernel.org, brauner@kernel.org,
daniel@iogearbox.net, haoluo@google.com, iii@linux.ibm.com,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
kuifeng@meta.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, mykolal@fb.com, sdf@google.com,
shuah@kernel.org, song@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH bpf-next v3 1/2] selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter
Date: Sun, 29 Oct 2023 10:06:46 -0700 [thread overview]
Message-ID: <60109bfb-1850-4b5b-87fd-c47a1e41bc2b@linux.dev> (raw)
In-Reply-To: <DB3PR10MB6835E9C8DFCA226DD6FEF914E8A3A@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM>
On 10/27/23 10:24 PM, Yuran Pereira wrote:
> As it was pointed out by Yonghong Song [1], in the bpf selftests the use
> of the ASSERT_* series of macros is preferred over the CHECK macro.
> This patch replaces all CHECK calls in bpf_iter with the appropriate
> ASSERT_* macros.
>
> [1] https://lore.kernel.org/lkml/0a142924-633c-44e6-9a92-2dc019656bf2@linux.dev
>
> Suggested-by: Yonghong Song <yonghong.song@linux.dev>
> Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2023-10-29 17:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1698461732.git.yuran.pereira@hotmail.com>
2023-10-28 5:24 ` [PATCH bpf-next v3 0/2] selftests/bpf: Replaces CHECK macros and adds malloc failure checks to bpf_iter Yuran Pereira
2023-10-28 5:24 ` [PATCH bpf-next v3 1/2] selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter Yuran Pereira
2023-10-29 17:06 ` Yonghong Song [this message]
2023-10-30 19:39 ` Kui-Feng Lee
2023-11-02 6:00 ` patchwork-bot+netdevbpf
2023-10-28 5:24 ` [PATCH bpf-next v3 2/2] selftests/bpf: Add malloc failure checks " Yuran Pereira
2023-10-29 17:07 ` Yonghong Song
2023-10-30 19:39 ` Kui-Feng Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60109bfb-1850-4b5b-87fd-c47a1e41bc2b@linux.dev \
--to=yonghong.song@linux.dev \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=iii@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuifeng@meta.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=sinquersw@gmail.com \
--cc=song@kernel.org \
--cc=yuran.pereira@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox