From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67407C433DB for ; Wed, 27 Jan 2021 07:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D7CD2072C for ; Wed, 27 Jan 2021 07:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233476AbhA0HTo (ORCPT ); Wed, 27 Jan 2021 02:19:44 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:11599 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S317501AbhA0AnO (ORCPT ); Tue, 26 Jan 2021 19:43:14 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DQPsr3HGvz1605l; Wed, 27 Jan 2021 08:41:04 +0800 (CST) Received: from [10.40.166.221] (10.40.166.221) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Wed, 27 Jan 2021 08:42:07 +0800 Message-ID: <6010B6DE.4060202@hisilicon.com> Date: Wed, 27 Jan 2021 08:42:06 +0800 From: Wei Xu User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Arnd Bergmann , Zhen Lei CC: Philipp Zabel , Rob Herring , linux-arm-kernel , devicetree , linux-kernel , Zhangfei Gao , Chen Feng , Manivannan Sadhasivam Subject: Re: [PATCH v3 2/4] arm64: dts: correct vendor prefix hisi to hisilicon References: <20201208124641.1787-1-thunder.leizhen@huawei.com> <20201208124641.1787-3-thunder.leizhen@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.166.221] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2021/1/27 6:23, Arnd Bergmann wrote: > On Tue, Dec 8, 2020 at 1:46 PM Zhen Lei wrote: >> >> The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly >> stated in "vendor-prefixes.yaml". >> >> Fixes: 35ca8168133c ("arm64: dts: Add dts files for Hisilicon Hi3660 SoC") >> Fixes: dd8c7b78c11b ("arm64: dts: Add devicetree for Hisilicon Hi3670 SoC") >> Signed-off-by: Zhen Lei >> Cc: Chen Feng >> Cc: Manivannan Sadhasivam > > I see this change in the pull request I got, but I'm a bit worried about the > incompatible binding change. Wouldn't the correct path forward be to > list both the correct and the incorrect properties, both in the dts file > and in the driver that interprets the properties? Thanks for the comment! The reset driver will look for "hisilicon" firstly and fall back to "hisi". And the DTS is shipped with the driver together. So I think there is no compatible issue here. Please let me know if missed anything. Thanks! Best Regards, Wei > > The binding file in this case would need to list the old name as deprecated, > though I'm not sure how that would work without causing a warning about > the unknown vendor prefix. > > Arnd > . >