From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C2BDC43214 for ; Wed, 1 Sep 2021 05:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A64060F3A for ; Wed, 1 Sep 2021 05:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242097AbhIAFrd (ORCPT ); Wed, 1 Sep 2021 01:47:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231195AbhIAFr3 (ORCPT ); Wed, 1 Sep 2021 01:47:29 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34782C061575; Tue, 31 Aug 2021 22:46:33 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id x27so4019043lfu.5; Tue, 31 Aug 2021 22:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7hRPX2dZswgsfHn1YLjeDaSIlOhVuOR93qiJSB96BN8=; b=uM7mCPdZWbjo9We9gk9bs3YDzJd/dn5hLXnWhFrMcvSeMphQBzz5E9SWhxzZ2sJkZZ xIXE/LY4sGKgw0rk/l+i0gIRSZlvF3n5STTEps54w3qnluO4Y8UiAS4pWV/UZ6picKtE 9a4HAuNiheFiJLCXiUb9PBUR4p84pk4FtuWayMc+Gib0Z7aP3VGdrI/O96IJQEyZqxJ/ 1EdV2XBMVGgneOA2ARgl7OA5DSe+dFYpvhcDSBQ45qceTvaMoRsmdhQoIudLuKQo+t8f wagdE/1/KWnnw0wLryzVUpIAcKLHFWz4v3B6BZkJ50jKgy8lOpo+d5BC8kGF8ObESlQP TigQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7hRPX2dZswgsfHn1YLjeDaSIlOhVuOR93qiJSB96BN8=; b=mnwxXeaRDzR6QeqRZtOIVNWIUva/3g0n06WUHz/geTtzT/zwzdMyHvqTwHb/Jk/Qo8 piXjp+yjTOdOQfdrLFfNu5zfYYxJyiM33meTO8Xf8/dWOUNq9LlRu9LGP9FucGyYns16 5YgIrTCB8lSCmRx0A6KJjXP+FVP2CsiFNerRyFsKi+cWqWUohS39zy1zwEMM5TrI1wtQ K1TZd7GxmRT2LuybmKDgw0h/T82DE++lS+vBjyUQ9ttiK7tatP99VtkKj/ITgSFbF8Lg yVBc/bEwg4oGouZZJH6CQruywu7RIIbacq/WH544SxGIRLEiBEHDy+1izSFTV9gHa72w wRvg== X-Gm-Message-State: AOAM5327uJxvmq2JxbOITvbOgqaUhlkTPiwMcIqcRXl8dj0lZ4TgeG5Y DLRAfe1miDQljW5XRuFjwXFn1JkeNOA= X-Google-Smtp-Source: ABdhPJzqfB1IavgEmOYEH0Pth4rYnyIB9Dlcg9NuqlXETLTG328MQjEVQe63D0kwcU/LUyaJpt1SRg== X-Received: by 2002:ac2:4c41:: with SMTP id o1mr4082926lfk.52.1630475191480; Tue, 31 Aug 2021 22:46:31 -0700 (PDT) Received: from [192.168.2.145] (46-138-26-37.dynamic.spd-mgts.ru. [46.138.26.37]) by smtp.googlemail.com with ESMTPSA id g38sm2109328lfv.210.2021.08.31.22.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 22:46:31 -0700 (PDT) Subject: Re: [PATCH v10 2/8] opp: Allow dev_pm_opp_set_clkname() to replace released clock To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Viresh Kumar , Stephen Boyd , Nishanth Menon , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20210831135450.26070-1-digetx@gmail.com> <20210831135450.26070-3-digetx@gmail.com> <20210901044235.2je35y3ajtctrall@vireshk-i7> From: Dmitry Osipenko Message-ID: <6010b244-4260-8ae9-2b8a-7fd689781d36@gmail.com> Date: Wed, 1 Sep 2021 08:46:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901044235.2je35y3ajtctrall@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 01.09.2021 07:42, Viresh Kumar пишет: > On 31-08-21, 16:54, Dmitry Osipenko wrote: >> The opp_table->clk is set to error once clock is released by >> dev_pm_opp_put_clkname(). This doesn't allow to set clock again, > > I am not sure why are you required to set the clk again here ? I mean, > users aren't expected to put clkname in the middle of using it. The > set-name API also checks that the OPP list should be empty in such a > case. I added explanatory comment to tegra_pmc_pd_dev_get_performance_state(), isn't it enough?