From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hardik Gajjar <hgajjar@de.adit-jv.com>,
Richard Acayan <mailingradian@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: Re-attach netif device to mirror detachment
Date: Thu, 28 Dec 2023 23:36:02 +0100 [thread overview]
Message-ID: <6019329.lOV4Wx5bFT@radijator> (raw)
In-Reply-To: <20231218164532.411125-2-mailingradian@gmail.com>
On Monday, December 18, 2023 17:45:33 CET, Richard Acayan wrote:
> In 6.7-rc1, there was a netif_device_detach call added to the
> gether_disconnect function. This clears the __LINK_STATE_PRESENT bit of
> the netif device and suppresses pings (ICMP messages) and TCP connection
> requests from the connected host. If userspace temporarily disconnects
> the gadget, such as by temporarily removing configuration in the gadget
> configfs interface, network activity should continue to be processed
> when the gadget is re-connected. Mirror the netif_device_detach call
> with a netif_device_attach call in gether_connect to fix re-connecting
> gadgets.
This fixes the NCM gadget on the PXA1908 phone Luca mentioned on v6.7-rc7.
Tested-by: Duje Mihanović <duje.mihanovic@skole.hr>
Regards,
Duje
next prev parent reply other threads:[~2023-12-28 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 16:45 [PATCH] usb: gadget: u_ether: Re-attach netif device to mirror detachment Richard Acayan
2023-12-28 21:59 ` Luca Weiss
2023-12-29 8:44 ` Greg Kroah-Hartman
2023-12-28 22:36 ` Duje Mihanović [this message]
2024-01-07 9:56 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-15 20:11 ` Ferry Toth
2024-01-21 13:23 ` Andy Shevchenko
2024-01-21 13:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6019329.lOV4Wx5bFT@radijator \
--to=duje.mihanovic@skole.hr \
--cc=gregkh@linuxfoundation.org \
--cc=hgajjar@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mailingradian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox