From: Valdis.Kletnieks@vt.edu
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>
Subject: Re: odd lockdep messages
Date: Mon, 08 Mar 2010 15:00:10 -0500 [thread overview]
Message-ID: <6025.1268078410@localhost> (raw)
In-Reply-To: Your message of "Mon, 08 Mar 2010 19:43:51 +0100." <1268073831.4997.69.camel@laptop>
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
On Mon, 08 Mar 2010 19:43:51 +0100, Peter Zijlstra said:
> On Mon, 2010-03-08 at 13:30 -0500, Valdis.Kletnieks@vt.edu wrote:
> > (Not sure when this started, just noticed it... Wasn't present in
> > 2.6.33-rc7-mmotm0210, is in 2.6.33-mmotm0302 and -mmotm0304).
> >
> > Seen in dmesg:
> > [ 1.012163] BUG: key ffff88011efbf500 not in .data!
> > [ 1.012284] BUG: key ffff88011efbf548 not in .data!
> Can that be wreckage due to the new per-cpu stuff?
>
> Its a message printed when the below function fails, and that per-cpu
> stuff seems the one most likely to break, given that there was quite a
> lot of churn in that department recently.
Would it make sense to stick some printk's on the 'return 1' cases
> /*
> * static variable?
> */
> if ((addr >= start) && (addr < end))
> return 1;
>
> if (arch_is_kernel_data(addr))
> return 1;
>
> #ifdef CONFIG_SMP
> /*
> * percpu var?
> */
> for_each_possible_cpu(i) {
> start = (unsigned long) &__per_cpu_start + per_cpu_offset(i);
> end = (unsigned long) &__per_cpu_start + PERCPU_ENOUGH_ROOM
> + per_cpu_offset(i);
>
> if ((addr >= start) && (addr < end))
> return 1;
or am I setting myself up for printk spam from hell if I do that?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2010-03-08 20:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 18:30 odd lockdep messages Valdis.Kletnieks
2010-03-08 18:43 ` Peter Zijlstra
2010-03-08 20:00 ` Valdis.Kletnieks [this message]
2010-03-09 1:54 ` Tejun Heo
2010-03-09 6:27 ` Valdis.Kletnieks
2010-03-09 6:44 ` Tejun Heo
2010-03-09 8:51 ` Valdis.Kletnieks
2010-03-09 14:18 ` Greg KH
2010-03-09 9:12 ` [PATCH] percpu,lockdep: implement and use is_static_percpu_address() Tejun Heo
2010-03-09 11:25 ` Peter Zijlstra
2010-03-09 11:42 ` Tejun Heo
2010-03-09 11:46 ` Tejun Heo
2010-03-09 11:52 ` Peter Zijlstra
2010-03-10 9:56 ` [PATCH 1/2] module: encapsulate percpu handling better and record percpu_size Tejun Heo
2010-03-10 9:57 ` [PATCH 2/2] percpu,module: implement and use is_kernel/module_percpu_address() Tejun Heo
2010-03-10 10:42 ` Peter Zijlstra
2010-03-29 8:26 ` [PATCH 1/2] module: encapsulate percpu handling better and record percpu_size Rusty Russell
2010-03-29 14:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6025.1268078410@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).