From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E810FC433EF for ; Thu, 31 Mar 2022 16:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239664AbiCaQJV (ORCPT ); Thu, 31 Mar 2022 12:09:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233760AbiCaQJS (ORCPT ); Thu, 31 Mar 2022 12:09:18 -0400 Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EC7A1F0CB9; Thu, 31 Mar 2022 09:07:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 6DF133D4E12; Thu, 31 Mar 2022 12:07:29 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JRYGslxfhPRR; Thu, 31 Mar 2022 12:07:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 18AAA3D4E11; Thu, 31 Mar 2022 12:07:29 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 18AAA3D4E11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1648742849; bh=jx6gZg83afo7MOp42wOlJpwj/Jm9YIc4UWICwF/Z2j0=; h=Date:From:To:Message-ID:MIME-Version; b=MxoPp8bKKDLmzIwiElUJrkDBFIkC/Tr0HvvD/oqo2jBdk4bEwG8EXtSenwTDFjJnn SOPpEU3sM57D0c1BOOeqkYki945UhL/vwX6bo8ovSg2g9M6HHA+yzOBFktuPqXiA0Q ahD2cyihm7uLzv9aQrAgu+MGPgF/lJ3UcxlVgAcVYSh9sRRVVQwvvI55Yspx+kxZUx C8oWwwpyDltHmDupteLWI4LIkO7VCDtHeL7X0goq1o9D39Hx1DM5Fhu+ovdF/EUtih hYhofjbzJ6Bi6Lmwl2d4BAhA/EOJz28Z9Mu/OufavmNCTE3rcLZ+2yEX/Ro0AUZmSS 7CP/ZgMXQ1J6w== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NP21fSpX9mGH; Thu, 31 Mar 2022 12:07:29 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 0588F3D4AEE; Thu, 31 Mar 2022 12:07:29 -0400 (EDT) Date: Thu, 31 Mar 2022 12:07:28 -0400 (EDT) From: Mathieu Desnoyers To: rostedt Cc: Masahiro Yamada , linux-kernel , Beau Belgrave , Masami Hiramatsu , linux-trace-devel , bpf , netdev , Alexei Starovoitov , Linus Torvalds , Michal Marek , ndesaulniers , Linux Kbuild mailing list Message-ID: <602770698.200731.1648742848915.JavaMail.zimbra@efficios.com> In-Reply-To: <20220331081337.07ddf251@gandalf.local.home> References: <20220330201755.29319-1-mathieu.desnoyers@efficios.com> <20220330162152.17b1b660@gandalf.local.home> <20220331081337.07ddf251@gandalf.local.home> Subject: Re: [PATCH] tracing: do not export user_events uapi MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4203 (ZimbraWebClient - FF98 (Linux)/8.8.15_GA_4232) Thread-Topic: tracing: do not export user_events uapi Thread-Index: soUfjk+gMtJ4HZ3jFxLYOaG8qofUxg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Mar 31, 2022, at 8:13 AM, rostedt rostedt@goodmis.org wrote: > On Thu, 31 Mar 2022 16:29:30 +0900 > Masahiro Yamada wrote: > >> Well, the intended usage of no-export-headers is to >> cater to the UAPI supported by only some architectures. >> We have kvm(_para).h here because not all architectures >> support kvm. >> >> If you do not want to export the UAPI, >> you should not put it in include/uapi/. >> >> After the API is finalized, you can move it to >> include/uapi. > > So a little bit of background. I and a few others thought it was done, and > pushed it to Linus. Then when it made it into his tree (and mentioned on > LWN) it got a wider audience that had concerns. After they brought up those > concerns, we agreed that this needs a bit more work. I was hoping not to do > a full revert and simply marked the change for broken so that it can be > worked on upstream with the wider audience. Linus appears to be fine with > this approach, as he helped me with my "mark for BROKEN" patch. > > Mathieu's concern is that this header file could be used in older distros > with newer kernels that have it implemented and added this to keep out of > those older distros. > > The options to make Mathieu sleep better at night are: > > 1) this patch > > 2) move this file out of uapi. I would be fine with this approach as well. This is simple enough: git mv include/uapi/linux/user_events.h include/linux/ and: diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c index 8b3d241a31c2..823d7b09dcba 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -18,7 +18,7 @@ #include #include #include -#include +#include #include "trace.h" #include "trace_dynevent.h" Including will continue to work even when the header is moved to uapi in the future. Thanks, Mathieu > > 3) revert the entire thing. > > I really do not want to do #3 but I am willing to do 1 or 2. > > -- Steve -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com