From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B0CD1537D4 for ; Thu, 23 Jan 2025 09:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737623975; cv=none; b=TKAq6jE1KMFInOE8/68NDHJ60ZkzaQecNKef8hSYPvTGaPMhhRgJrmZU+c4Ia8T2BcTvYps+jUfL3y58E88aPLdJRGQfpxc6bvGicJMxONNF24SOiYCcxNYPqx9HM9abS92sgQjAYmbRdUNBT3ItOvSuIkvz0938UMo6Av37gy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737623975; c=relaxed/simple; bh=184pJNujfL9vHWCY7XQB+Q6mbFfbqF6hTusp5iAYWo4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=awJT3H2+A51YqnynULDwIlFqllzfy/UxBza/tlwbdjeMOqrMMp8QiFlWZY1MqcPg7OYbK5uLskunvsDcex9qY+mUH6R+ZHJ9YQPCm3VplUKZXniTvN33h7aob5LQWPq13d7AD413qBTCngUOzZvuE/hiADS/r7lMM9QUpSaXMF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CauB7/J3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CauB7/J3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737623972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tpk29QNJr/u2raDKjwzZa/ftrpCg2eN5gxWBxwWhmCg=; b=CauB7/J3FBDaJxv8cZyvvOqfcHYMkyr/niSaeNAiri299EejY3JuHGNFER3GDBXMQ9GRJd DKcb6jwm8LvYudkt4iZSBYM3cMpAvJfDhdqBLhWLV8+So7Vks4+9iyDWHmbsjndGEdRsAq yTc6wJPlcdYzoeI/JrUMuobJTFhAPxw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-gX5EE2HvM2-8Y1Ge3FeMoA-1; Thu, 23 Jan 2025 04:19:31 -0500 X-MC-Unique: gX5EE2HvM2-8Y1Ge3FeMoA-1 X-Mimecast-MFC-AGG-ID: gX5EE2HvM2-8Y1Ge3FeMoA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43626224274so3739115e9.0 for ; Thu, 23 Jan 2025 01:19:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737623970; x=1738228770; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tpk29QNJr/u2raDKjwzZa/ftrpCg2eN5gxWBxwWhmCg=; b=Aq5lF+bFwFq4vqxJLQLK8nTIMfPA+8u30fFmHw/ir6PR0D2Rne/ksYEJH9pc4s/Fth QT2a5g+/8Y5NngMBc9sV8Uz3++TnK2sOcgOA+GvKTaXoeV48NSp7Xx2iOuj228w5pkDX XiSwn8lYjNi7S/d5lPw5CHdM0XN/IBO3gxJJOxGoH9opBYWfW5Cy5NgQpBj0i0Cc4Gu3 BSw8rmWsxKsZdtRQKbT0FVcxlDvYOF1CiQWyVrnjcS8aWyfKjPe7o4tDQwqEI5FhzhXZ BTOMgxd/gjSWT5aoebaCDPzemZ7ZiZcy0mx82I7LGcKambR727gl4r82+IiFMtzsv898 Kadw== X-Forwarded-Encrypted: i=1; AJvYcCUDR/vhVpRoLzmlwMVDY2ii0pDMY/KqGXSAyX7iE22NS7oyP2WAFkf/YJ79J9JxOEobmpigfbodYB99jXM=@vger.kernel.org X-Gm-Message-State: AOJu0YyuF+c+kD7WSuZNCSpY6/SSVizwQkapDmzvr85/x34qzhM7gQwt hjbZfV9uMgPnZtM5cq0PCQ5ZThGR3t+YRgkLc+5TQa+hDpJhZWG71BkUXfaWSH4b8dD3otAg+z5 mxQpOR4dVY8WhhE9AYG7NVaR7EoDIUV+1h/ZIGwayDuvUw12/m9A3ESoSfiTAzA== X-Gm-Gg: ASbGnctxkUFHJ1P6NRPZJgJSYkIHLQ1mxPCfZUxXyH+NFtgvJIsoytZHek+LbOzsH5O Ii4RRSDvEs5dXPi2v3RtS5hu6m3/3TUp7vdc77GyfVPozk0O0ueQ/irKpWFtHFYurQ3wVWwNHCg qdgWBjJlErY5xu91CtiNml+z2uA09/cH6xGLQPiRH9Md/RWzQxyxw0Mo3b81OVbNbY+XY7YalTM cE6EHKdin9/Flu90oCCX4V8MYagIt4QgyC+zlbs5bGbcmyJBaOrBcSIjksR1twzJ0wfkDs+4zp3 /Wiev5chCUWbAw6vsDS2FfgvGxQQdSb0Uhq9uQ7cYEluR6HFSWNh1UQh/uccrln8PRHJK3G8h9A EeZ2nFZhXrGCN10aEfokMhg== X-Received: by 2002:a05:6000:1565:b0:386:41bd:53a3 with SMTP id ffacd0b85a97d-38bf57c0716mr20592554f8f.50.1737623969870; Thu, 23 Jan 2025 01:19:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IELJvr120PccGhiPk+J8vS7HCzJfKTXcv+kUl4068w0UecLnu7MAo371oosFvaHdmBOdCHv5w== X-Received: by 2002:a05:6000:1565:b0:386:41bd:53a3 with SMTP id ffacd0b85a97d-38bf57c0716mr20592522f8f.50.1737623969485; Thu, 23 Jan 2025 01:19:29 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:b400:e20a:6d03:7ac8:f97d? (p200300cbc70bb400e20a6d037ac8f97d.dip0.t-ipconnect.de. [2003:cb:c70b:b400:e20a:6d03:7ac8:f97d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf2fc5caasm18686671f8f.0.2025.01.23.01.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 01:19:28 -0800 (PST) Message-ID: <604bbcbb-e728-4aef-b95b-13d50f8c4cc8@redhat.com> Date: Thu, 23 Jan 2025 10:19:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/compaction: fix UBSAN shift-out-of-bounds warning To: Liu Shixin , Andrew Morton , Kefeng Wang , Kemeng Shi , Baolin Wang , Mel Gorman , Matthew Wilcox , Nanyong Sun Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250123021029.2826736-1-liushixin2@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250123021029.2826736-1-liushixin2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23.01.25 03:10, Liu Shixin wrote: > syzkaller reported a UBSAN shift-out-of-bounds warning of (1UL << order) > in isolate_freepages_block(). The bogus compound_order can be any value > because it is union with flags. Add back the MAX_PAGE_ORDER check to fix > the warning. > > Fixes: 3da0272a4c7d ("mm/compaction: correctly return failure with bogus compound_order in strict mode") > Signed-off-by: Liu Shixin > --- > mm/compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a2b16b08cbbff..384e4672998e5 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -630,7 +630,8 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > if (PageCompound(page)) { > const unsigned int order = compound_order(page); > > - if (blockpfn + (1UL << order) <= end_pfn) { > + if ((order <= MAX_PAGE_ORDER) && hugetlb can exceed MAX_PAGE_ORDER, but end_pfn cannot. So I think what you have here will not change the exiting handling. Acked-by: David Hildenbrand Note: the whole "-1" with stride != 1 looks odd ... -- Cheers, David / dhildenb