RE: [RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

Woojung.Huh
2018-05-01T20:07:12Z

Hi Florian,

> Not sure I completely understand your suggestion, do you mean that I
> should break down the body of that function above such that there are
> per-speed lower level functions? Something like the pseudo-code below:
>
> genphy_set_test() {
> switch (mode) {
> case PHY_STD_TEST_MODE_100BASET2_1:
> ..
> case PHY_STD_TEST_MODE_100BASET2_3:
> return genphy_set_100baset2();
>
> case PHY_STD_TEST_MODE_1000BASET_1:
> ..
> case PHY_STD_TEST_MODE_1000BASET_4:
> return genphy_set_1000baset();
>
> case PHY_STD_TEST_MODE_8021BWQCQ_1:
> return genphy_set_100baset1();
>
> }
Yes, I should write pseudo code. Sorry about confusion.
User can override this function or expand to other modes.

Thanks.
Woojung