From: Guenter Roeck <linux@roeck-us.net>
To: Chu Lin <linchuyuan@google.com>,
jdelvare@suse.com, robh+dt@kernel.org,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, qiongwang@google.com,
zhongqil@google.com, jasonling@google.com, belgaied@google.com
Subject: Re: [PATCH] dt-bindings: hwmon: max20730: adding device tree doc for max20730
Date: Tue, 15 Sep 2020 20:04:24 -0700 [thread overview]
Message-ID: <6059ab76-02ff-0ab6-15bf-e34026a2f855@roeck-us.net> (raw)
In-Reply-To: <20200910170638.1985729-1-linchuyuan@google.com>
On 9/10/20 10:06 AM, Chu Lin wrote:
> Testing:
> make dt_binding_check
>
This isn't really an appropriate patch description.
> Signed-off-by: Chu Lin <linchuyuan@google.com>
> ---
> .../devicetree/bindings/hwmon/max20730.txt | 23 +++++++++++++++++++
AFAIK this needs to be written as .yaml file.
Guenter
> MAINTAINERS | 1 +
> 2 files changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/max20730.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/max20730.txt b/Documentation/devicetree/bindings/hwmon/max20730.txt
> new file mode 100644
> index 000000000000..3afb42b04567
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/max20730.txt
> @@ -0,0 +1,23 @@
> +max20730 properties
> +
> +Required properties:
> +- compatible: Must be one of the supported compatible strings:
> + "maxim,max20730" for max20730
> + "maxim,max20734" for max20734
> + "maxim,max20743" for max20743
> +- reg: I2C address
> +
> +Optional properties:
> +
> +- vout-voltage-divider
> + Resistance of the vout voltage divider.
> + Two numbers, the first number is the output resistor,
> + the second number is the total resistance.
> +
> +Example:
> +
> +max20730@10 {
> + compatible = "maxim,max20730";
> + reg = <0x10>;
> + vout-voltage-divider = <1000 2000>;
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0a6ac3f00ed5..a04bf34a65b8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12371,6 +12371,7 @@ W: http://www.roeck-us.net/linux/drivers/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> S: Maintained
> F: Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> +F: Documentation/devicetree/bindings/hwmon/max20730.txt
> F: Documentation/devicetree/bindings/hwmon/max31785.txt
> F: Documentation/devicetree/bindings/hwmon/ltc2978.txt
> F: Documentation/hwmon/adm1275
>
next prev parent reply other threads:[~2020-09-16 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 17:06 [PATCH] dt-bindings: hwmon: max20730: adding device tree doc for max20730 Chu Lin
2020-09-16 3:04 ` Guenter Roeck [this message]
2020-09-22 22:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6059ab76-02ff-0ab6-15bf-e34026a2f855@roeck-us.net \
--to=linux@roeck-us.net \
--cc=belgaied@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jasonling@google.com \
--cc=jdelvare@suse.com \
--cc=linchuyuan@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiongwang@google.com \
--cc=robh+dt@kernel.org \
--cc=zhongqil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox