From: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Nuno Das Neves <nunodasneves@linux.microsoft.com>,
Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>,
"open list:Hyper-V/Azure CORE AND DRIVERS"
<linux-hyperv@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
easwar.hariharan@linux.microsoft.com
Subject: Re: [PATCH] Drivers: hv: Use -ETIMEDOUT for HV_STATUS_TIME_OUT instead of -EIO
Date: Thu, 2 Oct 2025 15:30:22 -0700 [thread overview]
Message-ID: <605ce8cf-bdf9-45ca-b407-708625c8dcfa@linux.microsoft.com> (raw)
In-Reply-To: <20251002221347.402320-1-easwar.hariharan@linux.microsoft.com>
On 10/2/2025 3:13 PM, Easwar Hariharan wrote:
> Use the -ETIMEDOUT errno value as the correct 1:1 match for the
> hypervisor timeout status
>
> Fixes: 3817854ba89201 ("hyperv: Log hypercall status codes as strings")
> Signed-off-by: Easwar Hariharan <easwar.hariharan@linux.microsoft.com>
> ---
> drivers/hv/hv_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index 49898d10fafff..9b51b67d54cc8 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -781,7 +781,7 @@ static const struct hv_status_info hv_status_infos[] = {
> _STATUS_INFO(HV_STATUS_INVALID_LP_INDEX, -EIO),
> _STATUS_INFO(HV_STATUS_INVALID_REGISTER_VALUE, -EIO),
> _STATUS_INFO(HV_STATUS_OPERATION_FAILED, -EIO),
> - _STATUS_INFO(HV_STATUS_TIME_OUT, -EIO),
> + _STATUS_INFO(HV_STATUS_TIME_OUT, -ETIMEDOUT),
> _STATUS_INFO(HV_STATUS_CALL_PENDING, -EIO),
> _STATUS_INFO(HV_STATUS_VTL_ALREADY_ENABLED, -EIO),
> #undef _STATUS_INFO
Actually looking at the whole struct, it may be useful to also change at least some of
the following codes?
_STATUS_INFO(HV_STATUS_INVALID_ALIGNMENT, -EIO), -> EINVAL
_STATUS_INFO(HV_STATUS_ACCESS_DENIED, -EIO), -> EACCES
_STATUS_INFO(HV_STATUS_INVALID_PARTITION_STATE, -EIO), -> EINVAL
_STATUS_INFO(HV_STATUS_OPERATION_DENIED, -EIO), -> EACCES
_STATUS_INFO(HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE, -EIO), -> ERANGE
_STATUS_INFO(HV_STATUS_INSUFFICIENT_BUFFERS, -EIO), -> ENOBUFS
_STATUS_INFO(HV_STATUS_NOT_ACKNOWLEDGED, -EIO), -> EBUSY
_STATUS_INFO(HV_STATUS_INVALID_VP_STATE, -EIO), -> EINVAL
_STATUS_INFO(HV_STATUS_INVALID_LP_INDEX, -EIO), -> EINVAL
_STATUS_INFO(HV_STATUS_INVALID_REGISTER_VALUE, -EIO), -> EINVAL
_STATUS_INFO(HV_STATUS_VTL_ALREADY_ENABLED, -EIO), -> EBUSY
Nuno, Stas, others, what do you think?
Thanks,
Easwar (he/him)
next prev parent reply other threads:[~2025-10-02 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 22:13 [PATCH] Drivers: hv: Use -ETIMEDOUT for HV_STATUS_TIME_OUT instead of -EIO Easwar Hariharan
2025-10-02 22:30 ` Easwar Hariharan [this message]
2025-10-02 22:37 ` Stanislav Kinsburskii
2025-10-02 23:06 ` Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=605ce8cf-bdf9-45ca-b407-708625c8dcfa@linux.microsoft.com \
--to=easwar.hariharan@linux.microsoft.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nunodasneves@linux.microsoft.com \
--cc=skinsburskii@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox