From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752146AbdAYVXJ (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Jan 2017 16:23:09 -0500
Received: from mout.kundenserver.de ([217.72.192.73]:60062 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752050AbdAYVXH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Jan 2017 16:23:07 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Bilal Amarni <bilal.amarni@gmail.com>, catalin.marinas@arm.com,
        will.deacon@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM64: enable CONFIG_KEYS_COMPAT in Kconfig
Date: Wed, 25 Jan 2017 22:22:37 +0100
Message-ID: <6063453.l76hsdyeRH@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1485190992-86476-1-git-send-email-bilal.amarni@gmail.com>
References: <1485190992-86476-1-git-send-email-bilal.amarni@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:DKuorvo3QMtqouamu+XU3lxSh1tP0mlMNuOqdvUdZgft4d0cirH
 drUcqAKqbw2ggdui8SPm/+RwyZRTBW6Zx9v6Vm8uykf6NVanT/oXE9jqcGLbAJz8U2O3+kU
 Gf6+Gqlj7c6AKDNHDucYCMnwg851+MpqrJgmQntlh7JkGDba7FT6wP2uT/UOljomydvVkgw
 bnuVN/MY5msR+RPrD8d7g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:luJJHmlrKsE=:xelut7wuOZEDoEB3jbmsXm
 OHQgF5f44sbWSa1LDUNXzim5CLxzMFk7g4I1RjCwCgZO1WBlUojcMNA8Mw2Xql82gG31l+U3X
 IH46JdfCz2seCFSoP4fQR4amnTVZgCMR+//XBlaMfZGhb2nwmHlwjs1seuaNUVJ0LyP2LZfMG
 BUykUQonRGT56NPjLwGjgFVBl++zwNODBZEKWlg0x78IqzotMz0UzR6XW7l1ymFAFLYZYFKhd
 /TN97BwGq92hj+lRXvQFAn+SBxsSSSJNaVPVAhjmj6vX8KZIBihnLBIHGxphS/3zDxR01Aq4c
 PszzOEmtqmhSOpJXCWudljhmcKDNfZHhwULX+Q1WpOKevW4ZlK0lMGesX2BmlBGhm0vlT5t5d
 Us95dLzW7b3Q1bIJYy6D7rF/OiEZiz0kS0fof9U/rrz2iHANcKcmAye/jbEpULxi1ugRuCzu9
 Oe9bxNEKjGTotLZJOc3ZzMck13Eo/DhXOF7icIkE0N/VPwK8YBIT2k48ddpC2lxsCVxB1O3Ys
 F8L4T7ZOGexHQltbq57TtiUMlLE86fS0mBwk9QjFDaJ71uxsyIqb2hgioVf65WRglmqtEGWiW
 eMb0/udH97mq+2P3ftDzY0O7xET5nDzapmM/2Na+VLdDV6RIiy0NRN1uAZLuIMl2PrqXoXntD
 /WVaB7/U+hI0P1eD6EofkjTaYq6mGajIQwJ3lbzOqaTyYdPZRAvO5gQSyKCXtwBblCOCeSalA
 cINxOedlOJ6Ltpwo
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, January 23, 2017 6:03:12 PM CET Bilal Amarni wrote:
> Currently in 32-bit userspace calling the keyctl syscall returns an ENOSYS error.
> 
> This makes sure the compatibility wrapper is registered.
> 
> Signed-off-by: Bilal Amarni <bilal.amarni@gmail.com>

While this looks technically correct, it doesn't seem very nice to the
other 64-bit architectures that may also be missing this.

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1117421..d76f70b 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1030,6 +1030,10 @@ config SYSVIPC_COMPAT
>         def_bool y
>         depends on COMPAT && SYSVIPC
>  
> +config KEYS_COMPAT
> +       def_bool y
> +       depends on COMPAT && KEYS
> +

I see four copies of this in existing architectures, but none for
mips, parisc or tile. How about just moving this next to CONFIG_KEYS?

	Arnd