From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF32C22689C for ; Wed, 29 Apr 2026 06:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777442895; cv=none; b=uxnMKpm0Fupmyo+AezqImVUJaBHu/Kuh+TerM2XphJVNjtfAlOmSYgxAjY0gNExYF4YJBaWZxLrIicYlKoMxclVGTijFZvpNYxgn5W139aG6wFdFZYrCVYNDwB52N6acuGhDnmPEWS+pC9t4zi0AtI7ph6tGpzTp32wDEzVGM+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777442895; c=relaxed/simple; bh=YiD76tBApSgGt0ic+YskcqCt40dsogw2/Jn8fAZvLKg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PB/sNhUQV50tD7gfrZuJfMoVIlKJqCfyos+ak5hodUNiEMb04V61uKnsiM9ytkcP8OgQfB8P1YFmh86iBhpmho61YtB+ER1USIhO1uH/zDwiowhxDb60e+Eab0h3BroRyhLRGLTdZ4lU5CjBjkn498e6ItHDs1jH3Wl0jhvkSDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bw2ybRV0; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bw2ybRV0" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-38dd9f11a09so109046831fa.2 for ; Tue, 28 Apr 2026 23:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777442892; x=1778047692; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=t4S1Y3BUza+GCWjEiUtO3SVq14qyiAoiH8o/HDexclw=; b=bw2ybRV0oGFQoCWaLSSWaFhfJ3UCYX6iPoixKZGKY/s8bqjqvs8FGToPfafedBwWL4 po/l+zco8HawB58LAxgxu1JLnz/Vb2xv3F43Z8G4c/yqDud51CO6qrBHqJ8/kjqUyUtl pBzxAwNgjuFanfUSOHEmz5OId4wvTzGFCLfCjrdhSd8eKMJl+DI3/eHorLBosA/BgGwN K07jLSkR2gDlflg7gnyKT3xsLSyJYXVkCjce4pkJZreLlGCHDsLR+aui6bEIRwYPTuXZ DEeZfOemezl3ZqXLF6YPt5lMRlNcEXJFozswE5fCCWaeGo4uqIc+2kxBOCbKBqU9J8I2 Vt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777442892; x=1778047692; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t4S1Y3BUza+GCWjEiUtO3SVq14qyiAoiH8o/HDexclw=; b=sbKeKDufRdd8LszvtD7u4p7B/1KrQ3vfd641qJAB6gZKIQuZ3J/p/gSXOqqysFH2xm 4UA2wmmMlOfLwGpEhyBYOe8dyC0fqrkYTCLPt4hfDCbwqL5+k6jwX3OWQKpaC2E8+pMn bzJ/xDtsLBDLLFQHW8LxkFE4IbrX2P2PwjBtjMx7RTCQQ0/rAoc+HCvnaZT/56XBXaVs M2RE5TDi+5SvMfcMkc2MHBki+eOAG+aF0gvrmLQPxo6poG/xvx8agtmVrT4UpWGIlQZw ajbG7h2hf14MMAhq2YV0tvkUvXS0ZvwyHZS4fzfFRbTmEwTnpr/G0k+SbgQ4GViSZ329 f8vA== X-Forwarded-Encrypted: i=1; AFNElJ/Vyq0I2FCjPRGK8rn7hxufVnxFF3487e8+O5hY/v3+ifVvIfoIugIFtnPYBeV/iG30+Nqj7zU+RXLDsg8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6pQ3mFpRWQp6pdCUlKZDpoNUwY7/5mTkbJYNhlFnNZF7K/h4C 1bmf8aDrReCIvUF80bO30uWgU/l6QXVuHic5ZbDs3tHfxL0dNs1mHR1h X-Gm-Gg: AeBDievBWjPgztm7bOP0yUjIR4i06J3p6kWXAGuxQIPSzG8+24u6tKuCLHbJ8rGnT+P HaQd4R4VpF2eszfL/irvT5p+A3SjDRLJdlXKBnlk2HYefYIan5oSv1eT0AmfEE0VLonZgxQX60c Z9nYxN/pT6mgTZY6Iq1R6r6QeDe/pnv+u87RnVSR0LH3pMmmoV/yG/Lz/xHgEi2OUUFw3n0AFWl HMqR4GvTujoMUrzs18ewVsMgWC+KAnIoGNGf578h+DnIB24a7JdBPxxIp/MrFZ0apeMc1F2iaOt m9226Tn1n3/lxaHjLBD6Fxv24E3HUU4Fa36SEgDAX2huSFZ/BIR8ZEcoljb7vSxAFvyYgOuj9pp Gdz8UJ6FfltSRpMESgXlDBLD5g3dqLbFRih0Q20SFTJU25tVqprnGgVet2lb+BTOfBHebvFwQX8 erQqtQ6Hxth7Lwi2HtCXaLVuOkweVh1a5pzcVbc+sdy+a9swNrtFGTFJC0IBFgrGRm7uLyH5NmZ PdWdhfPZx+QhjNJHos= X-Received: by 2002:a05:651c:324c:b0:38c:50ed:d7ff with SMTP id 38308e7fff4ca-3924bbc98cemr9235611fa.2.1777442891625; Tue, 28 Apr 2026 23:08:11 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3924f96b1a0sm2373881fa.12.2026.04.28.23.08.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 23:08:10 -0700 (PDT) Message-ID: <607414e4-f134-4a7d-ad5a-ce48de507bc6@gmail.com> Date: Wed, 29 Apr 2026 09:08:09 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] mfd: rohm-bd71828: Use software nodes for gpio-keys From: Matti Vaittinen To: Dmitry Torokhov , Lee Jones Cc: Arnd Bergmann , linux-kernel@vger.kernel.org References: <20260427-rohm-software-nodes-v4-0-ffeb5b0c4774@gmail.com> <20260427-rohm-software-nodes-v4-1-ffeb5b0c4774@gmail.com> <391d679c-0d93-456a-977e-2b26b8135db9@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW In-Reply-To: <391d679c-0d93-456a-977e-2b26b8135db9@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29/04/2026 08:53, Matti Vaittinen wrote: > Hi Dee Ho, > > Thanks a ton Dmitry! This is looking very good to me now. I only have > one question below. > > On 28/04/2026 07:13, Dmitry Torokhov wrote: >> Refactor the rohm-bd71828 MFD driver to use software nodes for >> instantiating the gpio-keys child device, replacing the old >> platform_data mechanism. >> >> The power key's properties are now defined using software nodes and >> property entries. The IRQ is passed as a resource attached to the >> platform device. >> >> This will allow dropping support for using platform data for configuring >> gpio-keys in the future. >> >> Signed-off-by: Dmitry Torokhov >> --- >>   drivers/mfd/rohm-bd71828.c | 122 ++++++++++++++++++++++++++++++++ >> +------------ >>   1 file changed, 90 insertions(+), 32 deletions(-) >> >> diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c >> index a79f354bf5cb..a8bdb9c955a4 100644 >> --- a/drivers/mfd/rohm-bd71828.c >> +++ b/drivers/mfd/rohm-bd71828.c >> +    /* Node corresponding to gpio-keys device itself */ >> +    nodes[0].name = devm_kasprintf(dev, GFP_KERNEL, "%s-power-key", >> dev_name(dev)); >> +    if (!nodes[0].name) >> +        return -ENOMEM; > > Do we have any guidance/rules for naming the swnodes similar to > devicetree nodes? Do they need to be unique, and are they used for > anything? > > I am wondering if the dev_name() is needed or if we should have some > 'numbering'? I am not sure if the node names can be used for anything, > but in some cases adding IC-type to names will hurt the "generic > usability". On the other hand, if names need to be unique, then some > numbering might be needed (although, this is not critical for this > driver as it is very unlikely there is a system with more than one of > these PMICs). After thinking 2 seconds more... I suppose the dev_name() guarantees the name is unique :) So, please forget my babblings about numbering. -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~