From: David Howells <dhowells@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@list.de>,
"Christian Brauner" <christian@brauner.io>,
Matthew Wilcox <willy@infradead.org>,
"Jeff Layton" <jlayton@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc()
Date: Wed, 16 Aug 2023 14:00:47 +0100 [thread overview]
Message-ID: <608853.1692190847@warthog.procyon.org.uk> (raw)
In-Reply-To: <03730b50cebb4a349ad8667373bb8127@AcuMS.aculab.com>
David Laight <David.Laight@ACULAB.COM> wrote:
>
> Couldn't the relevant code directly call __copy_from_iter_mc() ?
> Or a version then checked iov_is_copy_mc() and then fell
> back to the standard function.
No, because the marked iterator is handed by the coredump code to
__kernel_write_iter() and thence on to who-knows-what driver - which will call
copy_from_iter() or some such. $DRIVER shouldn't need to know about
->copy_mc.
One thing I do wonder about, though, is what should happen if they call, say,
csum_and_copy_from_iter()? That doesn't have an _mc variant. Or what if they
extract the pages and operate directly on those?
David
next prev parent reply other threads:[~2023-08-16 13:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 12:07 [PATCH v3 0/2] iov_iter: Convert the iterator macros into inline funcs David Howells
2023-08-16 12:07 ` [PATCH v3 1/2] iov_iter: Convert iterate*() to " David Howells
2023-08-16 12:07 ` [PATCH v3 2/2] iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc() David Howells
2023-08-16 12:28 ` David Laight
2023-08-16 13:00 ` David Howells [this message]
2023-08-16 14:19 ` David Laight
2023-08-16 18:50 ` Linus Torvalds
2023-08-16 20:35 ` David Howells
2023-08-17 4:18 ` Linus Torvalds
2023-08-17 8:41 ` David Laight
2023-08-17 14:38 ` Linus Torvalds
2023-08-17 15:16 ` David Laight
2023-08-17 15:31 ` Linus Torvalds
2023-08-17 16:06 ` David Laight
2023-08-18 15:19 ` David Howells
2023-08-18 15:42 ` David Laight
2023-08-18 16:48 ` David Howells
2023-08-18 21:39 ` David Laight
2023-08-18 11:42 ` David Howells
2023-08-18 12:16 ` David Laight
2023-08-18 12:26 ` Matthew Wilcox
2023-08-18 12:41 ` David Laight
2023-08-18 13:33 ` David Howells
2023-08-18 11:39 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=608853.1692190847@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=axboe@kernel.dk \
--cc=christian@brauner.io \
--cc=hch@list.de \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox