From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933025Ab3FFMAv (ORCPT ); Thu, 6 Jun 2013 08:00:51 -0400 Received: from mout.gmx.net ([212.227.15.15]:62217 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932584Ab3FFMAu (ORCPT ); Thu, 6 Jun 2013 08:00:50 -0400 X-Authenticated: #181789 X-Provags-ID: V01U2FsdGVkX1+G4LFOj56GjBnpZWWFn+6tRa6w8w0eoh7leNvbTY bSn0YqdHY3NzYT From: Christian Eggers To: Matt Porter Cc: linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net Subject: [resubmit] spi: spi-davinci: Fix direction in dma_map_single() Date: Thu, 06 Jun 2013 14:00:44 +0200 Message-ID: <6095249.c3oSPaheWH@p2400> User-Agent: KMail/4.8.5 (Linux/3.9.4-1.g51bf0ff-desktop; KDE/4.8.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 048177ce3b3962852fd34a7e04938959271c7e70 (spi: spi-davinci: convert to DMA engine API) introduced a regression: dma_map_single() is called with direction DMA_FROM_DEVICE for rx and for tx. Signed-off-by: Christian Eggers Cc: stable@vger.kernel.org # v3.7.x+ Acked-by: Matt Porter --- --- drivers/spi/spi-davinci.c.orig 2013-04-18 20:54:02.728719412 +0200 +++ drivers/spi/spi-davinci.c 2013-04-18 20:54:51.900623956 +0200 @@ -608,7 +608,7 @@ static int davinci_spi_bufs(struct spi_d else buf = (void *)t->tx_buf; t->tx_dma = dma_map_single(&spi->dev, buf, - t->len, DMA_FROM_DEVICE); + t->len, DMA_TO_DEVICE); if (!t->tx_dma) { ret = -EFAULT; goto err_tx_map;