From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbbKIJv7 (ORCPT ); Mon, 9 Nov 2015 04:51:59 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:60376 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbbKIJv5 (ORCPT ); Mon, 9 Nov 2015 04:51:57 -0500 From: Arnd Bergmann To: Geert Uytterhoeven Cc: "David S. Miller" , huangdaode , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hisilicon: NET_VENDOR_HISILICON should depend on HAS_DMA Date: Mon, 09 Nov 2015 10:46:34 +0100 Message-ID: <6095433.PbGKVamcAs@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1447061670-19681-1-git-send-email-geert@linux-m68k.org> References: <1447061670-19681-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:nwTk20vauA4LAjfJuXLle2rtjF4HfVR8lUbOfxByudAg3TVKeEd EkdBVj4SgBuMf1d4gSlhCnR+IBUF7bH4cSPI0YKDRIQFrp/g5ojfYbwwligZ9wa/0uR0fOo gEsjJAJ1t7tH3HMv4OwO1KQqlpdvPqfjyEZdvcGQjcnBtEHux1C5/UAdIX9gV5drMx1h7Yo /myxDp0pw0HTjhpxPXg3A== X-UI-Out-Filterresults: notjunk:1;V01:K0:yeIQCbdAITk=:daIwiOOp0OdKgxM0PLJVZA kF0zDd34A52nV7l1wOErit9OuYEZir37wwExKBr94IToMyP0nB9jveM8boDVHNkINOCxdys1g UKvYcjuq21iqH/NS7UU9OLSW1SfN3P6wKJhr8GxId6qe+uxII3vuk+L+TCqIJOOfNAIPK/O3k B83/hvIB3CODUoNA65LGqkg+duopV3DjpLDFWJn2j6bjCiJ70yiwGbZFLY4ecJCUg6pw/dK/7 3IyFGt5hipHGahoSYbY7AjsXqR76Dixbn4foFUYrlqDb+xVtpmQUjrulGfKeyWNbSZXl4aMMs ws9PsLDmxsXB/0ETTHj7c+YGrmKfnpH4I8ovMD4LSDBtIpIkY1Hs3CyKMO2PmKANlnyRoMtWs OiF0mKWoeF2AIip/PIWMAAT55FMSOJo3GaIH4IfTJNb4AZxle4K+5EJLWBE2gP5SISzRtpE+P wcZUd4J4GNf2NNwpA7zXkgIFvkXA2gqGrDhzPBh2egguPP/LTPaKK7wDwovoYhRTf8cAjmUEO YDVNA0g1IXNhz7ngBBs2atvL8mVTcuF6R2aVDj4HDKI8Gu/cz68uamMdOzDEjni1TtdIr99v+ 2n1yi3lDxna3SJwCNtNX3ANph/Wl4+S3kGLyBqU1IF25bNwbSFvpGWmIUssIZJHpZ+tGk0Qex kUF31qCnzIrd15456YSwG3RaXJZuRefW1dZmIOs8rbKZazI/Ya9fe1enFWQu7JrOjgM/TEZgt fH1W8VjVjjdQEZEE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 09 November 2015 10:34:30 Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "dma_set_mask" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_unmap_single" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_unmap_page" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_mapping_error" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_map_page" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_supported" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_map_single" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_set_mask" [drivers/net/ethernet/hisilicon/hns/hns_dsaf.ko] undefined! > ERROR: "dma_supported" [drivers/net/ethernet/hisilicon/hns/hns_dsaf.ko] undefined! > ERROR: "dma_unmap_single" [drivers/net/ethernet/hisilicon/hns/hnae.ko] undefined! > ERROR: "dma_unmap_page" [drivers/net/ethernet/hisilicon/hns/hnae.ko] undefined! > ERROR: "dma_mapping_error" [drivers/net/ethernet/hisilicon/hns/hnae.ko] undefined! > ERROR: "dma_map_page" [drivers/net/ethernet/hisilicon/hns/hnae.ko] undefined! > ERROR: "dma_map_single" [drivers/net/ethernet/hisilicon/hns/hnae.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/net/ethernet/hisilicon/hix5hd2_gmac.ko] undefined! > ERROR: "dma_mapping_error" [drivers/net/ethernet/hisilicon/hix5hd2_gmac.ko] undefined! > ERROR: "dma_map_single" [drivers/net/ethernet/hisilicon/hix5hd2_gmac.ko] undefined! > ERROR: "dma_unmap_single" [drivers/net/ethernet/hisilicon/hix5hd2_gmac.ko] undefined! > ERROR: "dma_free_coherent" [drivers/net/ethernet/hisilicon/hix5hd2_gmac.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/net/ethernet/hisilicon/hip04_eth.ko] undefined! > ERROR: "dma_mapping_error" [drivers/net/ethernet/hisilicon/hip04_eth.ko] undefined! > ERROR: "dma_map_single" [drivers/net/ethernet/hisilicon/hip04_eth.ko] undefined! > ERROR: "dma_unmap_single" [drivers/net/ethernet/hisilicon/hip04_eth.ko] undefined! > ERROR: "dma_free_coherent" [drivers/net/ethernet/hisilicon/hip04_eth.ko] undefined! > > As this affects all of HNS_ENET, HNS_DSAF, HNS, HIX5HD2_GMAC, and > HIP04_ETH, add a dependency on HAS_DMA to the main NET_VENDOR_HISILICON > symbol to fix this. > > Signed-off-by: Geert Uytterhoeven > Acked-by: Arnd Bergmann