From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Robert Marko <robert.marko@sartura.hr>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <lee@kernel.org>,
<gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <luka.perkov@sartura.hr>
Subject: Re: [PATCH 3/3] tty: serial: atmel: make it selectable for ARCH_LAN969X
Date: Fri, 8 Nov 2024 14:25:31 +0100 [thread overview]
Message-ID: <609ef9c4-18cd-4a80-9821-5df27727772e@microchip.com> (raw)
In-Reply-To: <20241108112355.20251-3-robert.marko@sartura.hr>
On 08/11/2024 at 12:22, Robert Marko wrote:
A little commit message would be better.
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 45f0f779fbf9..e6cf20b845f1 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -128,7 +128,7 @@ config SERIAL_SB1250_DUART_CONSOLE
> config SERIAL_ATMEL
> bool "AT91 on-chip serial port support"
> depends on COMMON_CLK
> - depends on ARCH_AT91 || COMPILE_TEST
> + depends on ARCH_AT91 || ARCH_LAN969X ||COMPILE_TEST
Checkpatch.pl reports some "DOS line endings", you might need to fix this.
> select SERIAL_CORE
> select SERIAL_MCTRL_GPIO if GPIOLIB
> select MFD_AT91_USART
> --
> 2.47.0
Once fixed, you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks, best regards,
Nicolas
next prev parent reply other threads:[~2024-11-08 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 11:22 [PATCH 1/3] clk: lan966x: make it selectable for ARCH_LAN969X Robert Marko
2024-11-08 11:22 ` [PATCH 2/3] mfd: at91-usart: " Robert Marko
2024-11-08 13:20 ` Nicolas Ferre
2024-11-08 11:22 ` [PATCH 3/3] tty: serial: atmel: " Robert Marko
2024-11-08 13:25 ` Nicolas Ferre [this message]
2024-11-08 13:40 ` Robert Marko
2024-11-08 13:52 ` Nicolas Ferre
2024-11-14 20:36 ` [PATCH 1/3] clk: lan966x: " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609ef9c4-18cd-4a80-9821-5df27727772e@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=mturquette@baylibre.com \
--cc=robert.marko@sartura.hr \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox