From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>,
'Eric Dumazet' <eric.dumazet@gmail.com>,
Leonard Crestez <cdleonard@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>,
Enke Chen <enchen@paloaltonetworks.com>,
Wei Wang <weiwan@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: Use BIT() for OPTION_* constants
Date: Thu, 4 Nov 2021 09:38:26 -0700 [thread overview]
Message-ID: <60a45fd0-7055-e2ca-8254-1ccbc3fb7370@gmail.com> (raw)
In-Reply-To: <0b48f1ae32ba49f38dcfe11f912c4ace@AcuMS.aculab.com>
On 11/4/21 2:17 AM, David Laight wrote:
> From: Eric Dumazet
>> Sent: 03 November 2021 22:50
>>
>> On 11/3/21 3:17 PM, Leonard Crestez wrote:
>>> Extending these flags using the existing (1 << x) pattern triggers
>>> complaints from checkpatch. Instead of ignoring checkpatch modify the
>>> existing values to use BIT(x) style in a separate commit.
>>>
>>> Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
>>>
>>
>> Yes, I guess checkpatch does not know that we currently use at most 16 bits :)
>>
>> u16 options = opts->options;
>>
>> Anyway, this seems fine.
>
> Doesn't BIT() have a nasty habit of generating 64bit constants
> that just cause a different set of issues when inverted?
> It may be safe here - but who knows.
BIT() does not use/force 64bit constants, plain "unsigned long" ones.
Really this patch looks a nop to me.
prev parent reply other threads:[~2021-11-04 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 22:17 [PATCH] tcp: Use BIT() for OPTION_* constants Leonard Crestez
2021-11-03 22:49 ` Eric Dumazet
2021-11-04 9:17 ` David Laight
2021-11-04 16:38 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a45fd0-7055-e2ca-8254-1ccbc3fb7370@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=0x7f454c46@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=cdleonard@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=enchen@paloaltonetworks.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox