From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAEBF15748F for ; Tue, 22 Jul 2025 10:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753179432; cv=none; b=MapMPmBg1aiCALzciDawQvBcQkqfVO9tlgUD0hNm+UB5zpo0GJOzR3PW5SjFcgBvv8xNEfgTbNAWvalK7z0IO5MMkCf2WHDiDJRSHcje1mSmIqgszVVSyhVXVbjGJJXvyWmktZ0E77TaYTCZeT4FyoSG3qsyaCx5STE/2CSkF70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753179432; c=relaxed/simple; bh=8zuS2Vzm+tEOQV4oYYQFSbyQSMoniG/oIs0YaI2b90M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=egP6TZb6VaIkuwsBKSBj4fMVKlT/e59epEge4F4TAUh3u5HDEnLPv9tRLvRT4XeRBoW495t2/jGYwcMAzE7hPliKKt7NKuMdv/A7l0gBxGzxcf0H8ckIxr01S9RTSpW9s8vfWq/5iOWgfBZ7hVxmUT7NE/9FO2/AW7ZhiYGQQTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iQ3EoUxg; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iQ3EoUxg" Message-ID: <60ac707f-b57b-4f31-8c54-b59e75200181@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1753179426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tAK/szCwAUl9Nc/zNWVtzXtl2k6tosWPZ26fi0u2HZA=; b=iQ3EoUxg3VOUDHLv+lwTX/EjNWg7DAPbM3lfuvAwsE/IqEDS1E4TCxigwbP26N9AOtdrkn GHjtikCGMqUbCVjzpGOBqJnwk+o8t17ua6t0c+95gqEqNFPbBEpgDKI+JuOD8jQ1GalGQF HGOcwfbKtZS6NS0Gvl2njHNRJ6CYPhQ= Date: Tue, 22 Jul 2025 11:17:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 01/15] net: rnpgbe: Add build support for rnpgbe To: Yibo Dong Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, gur.stavi@huawei.com, maddy@linux.ibm.com, mpe@ellerman.id.au, danishanwar@ti.com, lee@trager.us, gongfan1@huawei.com, lorenzo@kernel.org, geert+renesas@glider.be, Parthiban.Veerasooran@microchip.com, lukas.bulwahn@redhat.com, alexanderduyck@fb.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250721113238.18615-1-dong100@mucse.com> <20250721113238.18615-2-dong100@mucse.com> <32fc367c-46a4-4c76-b8a8-494bf79a6409@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 22/07/2025 04:02, Yibo Dong wrote: > On Mon, Jul 21, 2025 at 02:30:40PM +0100, Vadim Fedorenko wrote: >> On 21/07/2025 12:32, Dong Yibo wrote: >>> Add build options and doc for mucse. >>> Initialize pci device access for MUCSE devices. >>> >>> Signed-off-by: Dong Yibo >>> --- [...] >>> + >>> +struct mucse { >>> + struct net_device *netdev; >>> + struct pci_dev *pdev; >>> + /* board number */ >>> + u16 bd_number; >>> + >>> + char name[60]; >>> +}; >>> + >>> +/* Device IDs */ >>> +#ifndef PCI_VENDOR_ID_MUCSE >>> +#define PCI_VENDOR_ID_MUCSE 0x8848 >>> +#endif /* PCI_VENDOR_ID_MUCSE */ >> >> this should go to include/linux/pci_ids.h without any ifdefs >> > > Got it, I will update this. As Andrew said, my suggestion is not fully correct, if you are not going to implement more drivers, keep PCI_VENDOR_ID_MUCSE in rnpgbe.h but without #ifdef >>> + >>> +#define PCI_DEVICE_ID_N500_QUAD_PORT 0x8308 >>> +#define PCI_DEVICE_ID_N500_DUAL_PORT 0x8318 >>> +#define PCI_DEVICE_ID_N500_VF 0x8309 >>> +#define PCI_DEVICE_ID_N210 0x8208 >>> +#define PCI_DEVICE_ID_N210L 0x820a >>> + >>> +#endif /* _RNPGBE_H */ >> >> [...] >>