Re: [PATCH v4 2/2] hwmon: add MP5920 driver

Guenter Roeck
2024-07-02T19:39:41Z

On 7/2/24 12:00, Thomas Weißschuh wrote:
> On 2024-07-02 14:52:51+0000, Alex Vdovydchenko wrote:
>> Add support for MPS Hot-Swap controller mp5920. This driver exposes
>> telemetry and limit value readings and writings.
>>
>> Signed-off-by: Alex Vdovydchenko <xzeol@yahoo.com>
>> ---
>> Documentation/hwmon/index.rst | 1 +
>> Documentation/hwmon/mp5920.rst | 91 +++++++++++++++++++++++++++++++++
>> drivers/hwmon/pmbus/Kconfig | 9 ++++
>> drivers/hwmon/pmbus/Makefile | 1 +
>> drivers/hwmon/pmbus/mp5920.c | 93 ++++++++++++++++++++++++++++++++++
>> 5 files changed, 195 insertions(+)
>> create mode 100644 Documentation/hwmon/mp5920.rst
>> create mode 100644 drivers/hwmon/pmbus/mp5920.c
>
> The entry in MAINTAINERS seems to be missing.
>

That isn't mandatory; checkpatch asks for it, but I prefer not to have it
in the first place if the submitter doesn't really plan to maintain it.

> Otherwise:
>
> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>
>

Thanks,
Guenter