From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C9B733557C for ; Thu, 13 Nov 2025 10:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763031591; cv=none; b=OHDHS6Tc528Ts2P7JP7+EXPcC7TAyyMc5iM4j4ES8Z9qLv4wEv2bWVV6zFKDoIYmOVV0R7DVQODpM/BucQ377GHdTyMF4zN8ckTxLMj60i1toAuni/fEWwOrYsm2/PpbzESlY9TQgP4iil5Ts3N5mw05gHbXjQVVgQX91q+8/dI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763031591; c=relaxed/simple; bh=ugZFlfc+l2S+0zWCSf1PxybsJPWJGmiF5NzWiKPgTzM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Nf2GBGCyhLxK9K6JKneTK1WCE5WO18AIlIiUAOBwq9u+WhqauIUlcQgTrJ9G+5gqKko40RdqPWvTTe9oVisoZvRD+BnVmLYL9/LtwT5yY7N6gM8z14uoQrsECu0HtOQ1Mr4cXX7hAK8yfwOVt6dP00UXDqbXoS6ZbJBAwAboRzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iQ3gJ3CK; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iQ3gJ3CK" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47775fb6cb4so4871145e9.0 for ; Thu, 13 Nov 2025 02:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763031586; x=1763636386; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DEJC7gRTebDUaxwAOnQ9BV9gIzheu37nMO4ePUyMYEM=; b=iQ3gJ3CK+EvoGocot/Chl1ETCyQHG6GXKwpS32/w52vYJtH8PF+c+cxZV/V6Y1PWxe qQBxxItLa7wBBe1zZ9JtuCwAePN8hF0IEfGpf7mwgZHswAUr5F5z5W2+oHO8d/5u8Kqn ZcpzG3QzVsMaDloGTcuam0H7i2Vx7Tf3pNPAOErn3+NNfXOeDcu5CkOla0vCNq6j0eRq kb7ALrEYpAPxkYAqzmZhzie7mwW91sUlFc0t5W5GEqiI2Wu+s3s92KmvLriUjGRIAv08 Sp/gVpLYzBsC4LCG1dy2lrfz5a117+bAMyb8ZQCcKJw3j3+ZsX69A4qprDhlEiWVh4NE qEcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763031586; x=1763636386; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DEJC7gRTebDUaxwAOnQ9BV9gIzheu37nMO4ePUyMYEM=; b=s/38nR1gPy5ePVytOAmf5svFfoJHqgYIGhqcAE9HlhlUyhB7VNkOPFmes2AsQCvUFW rKgfk805KFJUBSgr00qCncogul1vAyW1rLI8zKyAKpzc+I66b/+KHgyCXuWV2T4E7/4w UTLM0pn68h2cTXZwXMgPJ6dXXR4UaLlnb9uHtBC8D6Rv12E47YqC5EgKLscodF/WIVpO Nfvl2lYFe95gFljkbRrKl3ZxqHxieEOcajVeRynwnqjgTcRExZ3ZXbqEHywwdFbsQsa4 3lqnet2GYKBSdvREwCiSq8KyBXVHMxFIPvHEsrgUmlprQhdL1HCUf63LvBpxwIi8zef3 tU1A== X-Forwarded-Encrypted: i=1; AJvYcCWsdDrlSd8gD9ls2xtv9TMSiq/Go5wT3xX4R0jhvoFIfyowJsPtVXcf1K4rk8EbsibRMSXNtBCagsRAExg=@vger.kernel.org X-Gm-Message-State: AOJu0YyzQYAzbH7PbpL2C+VoYdWbcdyrZTFr/oFPnh+kMIkT0TutdNfR AzURnZmuz0ofgPuyx2OEHndqhgetHwIlaKfzUBtg7JLVBj1X/J4Rj+d0 X-Gm-Gg: ASbGncsECXwmfAvMec0ldWv5wWHAgRwPRL1z7j5/EKZHqsrHohqobXOs6TUm7E0PA5l /p1HjL/vkO8eosIfM1IEdTaMNYrl7qM5bXAuUQj17VA2Hybu0F5hZXIh1GUzUlbM+3vw8KgBqEw Tue2jJ/1u3JPs0RcFTqgoO8sESROuW9/NkaGq0vE5FtmJmF13HVdJKIcn/QthVYwjmA6bXry0sD JDQDNK5vE+Nuj9B7fztH3iRMsBD4IwN9uHgVnFFiEsLEhQ9dOV7x2n7ooyEoAgWUhi4EAe6Cz9k N4mrsYXX/UZcO70rP1QSpQLPLHwufuOCJgdk4KwFHI30OX9n/O3bDOPAXh5IL0EE9JMMzsyRUNh uyPoZWaoDcVTnwL0L9n9sazg1gx+ZBfi9q7bc9U+WXyWUdWFFX+lisHROS0F7cW9eBzEbrDjg9z pzQaKzJapnK8DhdgxEOPJt X-Google-Smtp-Source: AGHT+IFCpVKEMNGa1TiGFz1du/mkrAjFihX7xaQjFh0qLSpjr6GgH+cPEzn+8D8uBc5acStTR7O0cA== X-Received: by 2002:a05:600c:4694:b0:477:7f4a:44ae with SMTP id 5b1f17b1804b1-477870bf2fdmr57386475e9.39.1763031586191; Thu, 13 Nov 2025 02:59:46 -0800 (PST) Received: from [10.158.36.109] ([72.25.96.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b513sm3255195f8f.30.2025.11.13.02.59.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 02:59:45 -0800 (PST) Message-ID: <60c0b805-92e9-48c0-a4dc-5ea071728b3d@gmail.com> Date: Thu, 13 Nov 2025 12:59:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 0/6] net/mlx5e: Speedup channel configuration operations To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Tariq Toukan , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" Cc: Saeed Mahameed , Leon Romanovsky , Mark Bloch , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Gal Pressman , Leon Romanovsky , Moshe Shemesh , William Tu , Dragos Tatulea , Nimrod Oren , Alex Lazar References: <1762939749-1165658-1-git-send-email-tariqt@nvidia.com> <874iqzldvq.fsf@toke.dk> <89e33ec4-051d-4ca5-8fcd-f500362dee91@gmail.com> <87ms4rjjm0.fsf@toke.dk> Content-Language: en-US From: Tariq Toukan In-Reply-To: <87ms4rjjm0.fsf@toke.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/11/2025 18:33, Toke Høiland-Jørgensen wrote: > Tariq Toukan writes: > >> On 12/11/2025 12:54, Toke Høiland-Jørgensen wrote: >>> Tariq Toukan writes: >>> >>>> Hi, >>>> >>>> This series significantly improves the latency of channel configuration >>>> operations, like interface up (create channels), interface down (destroy >>>> channels), and channels reconfiguration (create new set, destroy old >>>> one). >>> >>> On the topic of improving ifup/ifdown times, I noticed at some point >>> that mlx5 will call synchronize_net() once for every queue when they are >>> deactivated (in mlx5e_deactivate_txqsq()). Have you considered changing >>> that to amortise the sync latency over the full interface bringdown? :) >>> >>> -Toke >>> >>> >> >> Correct! >> This can be improved and I actually have WIP patches for this, as I'm >> revisiting this code area recently. > > Excellent! We ran into some issues with this a while back, so would be > great to see this improved. > > -Toke > Can you elaborate on the test case and issues encountered? To make sure I'm addressing them.